Refactor #14823
open
Stop saving _timestamp fact
Description
We ignore this fact via no_timestamp scope anyway so we can avoid importing it completely. The base can be taken from https://github.com/theforeman/foreman/pull/3465
Updated by Marek Hulán over 8 years ago
- Related to Bug #13819: Fact imports fail with: Validation failed: Fact name has already been taken added
Updated by Michael Brown over 8 years ago
Marek Hulán wrote:
We ignore this fact via no_timestamp scope anyway so we can avoid importing it completely. The base can be taken from https://github.com/theforeman/foreman/pull/3465
Tested commit from Marek in our environment: https://github.com/ares/foreman/commit/36b39ba7f1dc004a44d7c1f0ef0f1993a18e9519
New facts added successfully. Hoping this can be pulled into the 1.10.4 maintenance release, as we're planning a large rollout based on Foreman 1.10 and Katello 2.4.
Thanks for your help with this Marek!
/Mike
Updated by Marek Hulán over 8 years ago
I believe this comment belongs to #13819, anyway I'll set the target there and we'll see.
Updated by Michael Brown over 6 years ago
Updated by Marek Hulán over 6 years ago
- Difficulty set to easy
I think we're still saving _timestamp fact to DB and using :no_timestamp_facts scope for hiding it https://github.com/theforeman/foreman/search?utf8=%E2%9C%93&q=no_timestamp_facts&type=
so this should remain open
Updated by Ohad Levy over 6 years ago
AFAIR we use the timestamp fact as a means to keep the last compile field (https://github.com/theforeman/foreman/blob/develop/app/models/host/base.rb#L151) - I'm not sure if we really use that so ymmv