Project

General

Profile

Bug #14960

alias_method_chain in settings helper breaks plugins

Added by Ori Rabin about 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Adding select boxes to Settings changed the value method in settings_helper: https://github.com/theforeman/foreman/commit/ad603e4023c5400c51674f1fa3635565f7b3b552#diff-99f01fed5094bece4bbc97c882f4b666R4.
Discovery extends the settings_helper and adds it's own alias_method_change for value.
As a result trying to use discovery returns the error: `alias_method': undefined method `value' for module `#<Module:0x00000006f36320>' (NameError)


Related issues

Related to Foreman - Feature #3200: Add select boxes to SettingsClosed2013-10-04
Related to Discovery - Refactor #14964: Use collections settings API for taxonomyClosed2016-05-09

Associated revisions

Revision f88a7a55 (diff)
Added by Tomer Brisker about 6 years ago

Fixes #14960 - Improve settings helper for collections

History

#1 Updated by Ori Rabin about 6 years ago

#2 Updated by Ori Rabin about 6 years ago

  • Subject changed from discovery settings use a method that no longer exists in core to discovery settings use a method that now uses alias_method_chain in core

#3 Updated by Tomer Brisker about 6 years ago

  • Project changed from Discovery to Foreman
  • Subject changed from discovery settings use a method that now uses alias_method_chain in core to alias_method_chain in settings helper breaks plugins
  • Assignee changed from Ori Rabin to Tomer Brisker

#4 Updated by Dominic Cleal about 6 years ago

  • Category set to Settings
  • Legacy Backlogs Release (now unused) set to 136

#5 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/271 added

#6 Updated by Dominic Cleal about 6 years ago

  • Status changed from Ready For Testing to Assigned
  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/271)

#7 Updated by Lukas Zapletal about 6 years ago

  • Related to Refactor #14964: Use collections settings API for taxonomy added

#8 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3503 added

#9 Updated by Anonymous about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF