Project

General

Profile

Actions
Copy link

Bug #14960

closed

alias_method_chain in settings helper breaks plugins

Added by Ori Rabin over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Settings
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3503
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Adding select boxes to Settings changed the value method in settings_helper: https://github.com/theforeman/foreman/commit/ad603e4023c5400c51674f1fa3635565f7b3b552#diff-99f01fed5094bece4bbc97c882f4b666R4.
Discovery extends the settings_helper and adds it's own alias_method_change for value.
As a result trying to use discovery returns the error: `alias_method': undefined method `value' for module `#<Module:0x00000006f36320>' (NameError)

Related issues 2 (0 open — 2 closed)

Related to Foreman - Feature #3200: Add select boxes to SettingsClosedAmir Fefer10/04/2013Actions
Related to Discovery - Refactor #14964: Use collections settings API for taxonomyClosedLukas Zapletal05/09/2016Actions
Actions
Copy link
 #1

Updated by Ori Rabin over 8 years ago

Actions
Copy link
 #2

Updated by Ori Rabin over 8 years ago

  • Subject changed from discovery settings use a method that no longer exists in core to discovery settings use a method that now uses alias_method_chain in core
Actions
Copy link
 #3

Updated by Tomer Brisker over 8 years ago

  • Project changed from Discovery to Foreman
  • Subject changed from discovery settings use a method that now uses alias_method_chain in core to alias_method_chain in settings helper breaks plugins
  • Assignee changed from Ori Rabin to Tomer Brisker
Actions
Copy link
 #4

Updated by Dominic Cleal over 8 years ago

  • Category set to Settings
  • Translation missing: en.field_release set to 136
Actions
Copy link
 #5

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/271 added
Actions
Copy link
 #6

Updated by Dominic Cleal over 8 years ago

  • Status changed from Ready For Testing to Assigned
  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/271)
Actions
Copy link
 #7

Updated by Lukas Zapletal over 8 years ago

  • Related to Refactor #14964: Use collections settings API for taxonomy added
Actions
Copy link
 #8

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3503 added
Actions
Copy link
 #9

Updated by Anonymous over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF