Project

General

Profile

Refactor #14995

Default log level for smart-proxy should be INFO

Added by Lukas Zapletal over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Core
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I believe this is a regression and it was set to INFO previously. Currently I see this set to ERROR which is not good. There is nothing that can tell you that requests are actually coming to proxy. Since we rotate our logs and traffic is not huge, I see no reason not to set it to INFO. Our logging is clean:

I, [2016-05-11T03:28:04.686868 #1069]  INFO -- : 127.0.0.1 - - [11/May/2016 03:28:04] "GET /features HTTP/1.1" 200 83 0.0044
I, [2016-05-11T03:28:04.770358 #1069]  INFO -- : 127.0.0.1 - - [11/May/2016 03:28:04] "GET /ssh/pubkey HTTP/1.1" 200 438 0.0007
I, [2016-05-11T03:28:04.830933 #1069]  INFO -- : 127.0.0.1 - - [11/May/2016 03:28:04] "GET /features HTTP/1.1" 200 83 0.0008

Associated revisions

Revision b0ae4e0d (diff)
Added by Lukas Zapletal over 5 years ago

Fixes #14995 - proxy default log is INFO

History

#1 Updated by Dominic Cleal over 5 years ago

  • Project changed from Installer to Smart Proxy
  • Category changed from Foreman modules to Core

The installer follows the smart proxy default, which is (and has been for as long as I'm aware) set to ERROR - per settings.yml.example and lib/proxy/settings/global.rb.

#2 Updated by Lukas Zapletal over 5 years ago

  • Tracker changed from Bug to Refactor

Changing this to proposal, I see no reason why to avoid INFO.

#3 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/smart-proxy/pull/417 added

#4 Updated by Anonymous over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal over 5 years ago

  • Legacy Backlogs Release (now unused) set to 136

Also available in: Atom PDF