Project

General

Profile

Refactor #15037

Improve editable elements

Added by Amir Fefer over 2 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Foreman uses Jeditable jquery plugin for editable elements.
This plugin is unmaintained, and lack of some features.

A better alternative is x-editable, well maintained and supports much more inputs:

  • text
  • textarea
  • select
  • date
  • datetime
  • dateui
  • combodate
  • html5types
  • checklist
  • wysihtml5
  • typeahead
  • typeaheadjs
  • select2

Related issues

Related to Katello - Bug #15832: Red Hat Repositories page not loadingClosed2016-07-25
Related to Foreman - Bug #16075: Changing any setting fails: Invalid authenticity tokenClosed2016-08-11

Associated revisions

Revision d1635077 (diff)
Added by Amir Fefer about 2 years ago

Fixes #15037 - Improves editable elements in settings

Revision 42917573 (diff)
Added by Dominic Cleal about 2 years ago

refs #15037 - require rubygem-x-editable-rails

History

#1 Updated by Amir Fefer over 2 years ago

  • Category set to Settings

#2 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3523 added

#3 Updated by Amir Fefer about 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal about 2 years ago

  • Legacy Backlogs Release (now unused) set to 160

#5 Updated by Andrew Kofink about 2 years ago

  • Related to Bug #15832: Red Hat Repositories page not loading added

#6 Updated by Dominic Cleal about 2 years ago

  • Related to Bug #16075: Changing any setting fails: Invalid authenticity token added

#7 Updated by Dominic Cleal almost 2 years ago

Please note that a stored XSS vulnerability has been identified in Foreman 1.11.0 to 1.12.4 identified as CVE-2016-8639 (details on https://theforeman.org/security.html soon) that has been fixed by this refactoring. It was originally introduced in #13721.

Also available in: Atom PDF