Project

General

Profile

Actions

Bug #15142

closed

Some tests in hammer-cli-katello use MiniTest's assert() method improperly

Added by Andrew Kofink almost 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Hammer
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1338813
Description of problem:
The assert() method is improperly used in several locations, causing tests to pass when they should potentially fail.

Version-Release number of selected component (if applicable):
upstream

How reproducible:
always

Steps to Reproduce:
N/A

Actual results:
N/A

Expected results:
N/A

Additional info:
Most of these tests use assert() like assert_equal(x, y), where the assertion is dependent on the equality of x and y. The assert(x, msg) method asserts that x is a true value, and provides msg when the assertion fails.

Actions #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/hammer-cli-katello/pull/402 added
Actions #2

Updated by Eric Helms almost 8 years ago

  • translation missing: en.field_release set to 143
Actions #3

Updated by Anonymous almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF