Project

General

Profile

Actions

Bug #15155

closed

Importing / publishing a CV with a class with a different default for a parameter wrongfully triggers validation and ISE

Added by Tomer Brisker over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1334520
Description of problem:
A new version of a module, with a new default for a parameter seems to trigger Foreman's validation of parameters: the new default is seen as a changed parameter and Foreman errors out with:

ActiveRecord::RecordInvalid: Validation failed: Override must be true to edit the parameter

Version-Release number of selected component (if applicable):
6.2.0 beta SNAP 10

How reproducible:
using hammer proxy import-classes --environment xxx --id xx

Steps to Reproduce:
1. create two environments, with the same simple module with one parameter in each
2. import the first environment
3. change the parameter in the second env and then import it

Actual results:
First import of second environment might(?) be ok, but second import will trigger validation errors like above.

Expected results:
environment with changed module is imported

Additional info:
I tried changing the version of the module to see if that would help to not trigger the validation, but it doesn't

For my simple test case, actually setting override to true for the parameter allowed me to import the environment.

Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3546 added
Actions #2

Updated by Ori Rabin over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal over 8 years ago

  • Category set to Parameters
  • Translation missing: en.field_release set to 136
Actions

Also available in: Atom PDF