Project

General

Profile

Bug #15246

Inline Parameter editing - brackets missing on first edit of an array

Added by Michael Hurn almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Smart Variables
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I may be missing something but the first time I try and edit an array. I get the array values less the [, ], & "s. I.e. just a simple comer separated string :(

If I put them back future edits are ok. Also if my Puppet modules have a blank array [] when I go to edit I lose the [] then I can edit I have to add the [, ] , & " but at least the values are good after that.

If I cancel the edit I get the [] back.

This can be tested with the NTP module.
See also https://groups.google.com/forum/#!topic/foreman-users/C8UalPWWckY

Associated revisions

Revision b9f3561f (diff)
Added by Ori Rabin almost 4 years ago

Fixes #15246 - correctly override array params

When editing inline array params would be parsed as js objects.
This was a result of using the jquery data api.

Revision e8a46acb (diff)
Added by Ori Rabin almost 4 years ago

Fixes #15246 - correctly override array params

When editing inline array params would be parsed as js objects.
This was a result of using the jquery data api.

(cherry picked from commit b9f3561f251afd652b5cd9070d058679c88d226c)

Revision 8e2ecc1d (diff)
Added by Ori Rabin almost 4 years ago

Fixes #15246 - correctly override array params

When editing inline array params would be parsed as js objects.
This was a result of using the jquery data api.

(cherry picked from commit b9f3561f251afd652b5cd9070d058679c88d226c)

History

#1 Updated by Dominic Cleal almost 4 years ago

  • Subject changed from Inline Parameter editing - Error first time edit of an array to Inline Parameter editing - brackets missing on first edit of an array
  • Category set to Smart Variables

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ori Rabin
  • Pull request https://github.com/theforeman/foreman/pull/3565 added

#3 Updated by Ori Rabin almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 159

#5 Updated by Ori Rabin over 3 years ago

  • Bugzilla link set to 1405118

Also available in: Atom PDF