Project

General

Profile

Bug #15247

toplevel constant PuppetError referenced by MailNotification::PuppetError

Added by Dominic Cleal almost 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
Dominic Cleal
Category:
E-Mail
Target version:
1.12.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3562
Fixed in Releases:
Found in Releases:

Description

When running test/unit/report_importer_test.rb, some warnings are logged (on Ruby 2.3.0 at least):

/home/dcleal/code/foreman/foreman/app/services/report_importer.rb:102: warning: toplevel constant PuppetError referenced by MailNotification::PuppetError

The class mentioned should simply be PuppetError - it extends MailNotification, but is not namespaced under it.

Related issues

Related to Foreman - Feature #9470: Option to send Puppet error emails for all hosts to a userClosed2015-02-19

Associated revisions

Revision 4552607a (diff)
Added by Dominic Cleal almost 6 years ago

fixes #15247 - reference PuppetError class correctly

Revision 55067dfb (diff)
Added by Dominic Cleal almost 6 years ago

fixes #15247 - reference PuppetError class correctly

(cherry picked from commit 4552607af2b4db8e7ae508f91bcde1c40b05a779)

History

#1 Updated by Dominic Cleal almost 6 years ago

  • Related to Feature #9470: Option to send Puppet error emails for all hosts to a user added

#2 Updated by The Foreman Bot almost 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3562 added

#3 Updated by Dominic Cleal almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF