Bug #15291: hammer host-collection add-host/remove-host always return success - Katello - Foreman

Bug #15291

hammer host-collection add-host/remove-host always return success

Added by Andrew Kofink about 6 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Low

Assignee:

Andrew Kofink

Category:

Hammer

Target version:

Katello 3.2.0

Difficulty:

medium

Triaged:

Bugzilla link:

1335559

Pull request:

https://github.com/Katello/katello/pull/6229

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1335559
Description of problem:
The `hammer host-collection add-host/remove-host` commands always return success messages, regardless of whether the hosts added/removed are found.

Version-Release number of selected component (if applicable):
6.1,6.2,devel

How reproducible:
Always

Steps to Reproduce:
1. Run the following hammer commands with a valid host collection but invalid host ids
`hammer host-collection add-host --id 1 --host-ids 2354,34`
`hammer host-collection remove-host --id 1 --host-ids 2354,34`

Actual results:
The host(s) has been added
The host(s) has been removed

Expected results:
Could not find hosts with IDs 2354,34. No hosts added.
Could not find hosts with IDs 2354,34. No hosts removed.

Additional info:

Related issues

Associated revisions

Revision 2e3e5edf (diff)
Added by Andrew Kofink about 6 years ago

Fixes #15291 - Add detailed error messages to HCs (#6229)

Add detailed error messages to host_collections#add_hosts and
host_collections#remove_hosts for the cases when a host cannot be
found and when a host already exists/doesn't exist on the host
collection, respectively.