Project

General

Profile

Bug #15308

editing puppet class parameter with arrays and hashes fails when not overriding

Added by Ohad Levy almost 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

steps to reproduce:

a puppet class with either hash or array parameters, that override is false.

try to save:

always get an error message - "
"Override must be true to edit the parameter"


Related issues

Related to Foreman - Bug #13727: Error not raised while setting default value when 'Override' set to False for parameter.Closed2016-02-16

Associated revisions

Revision 85c9be5a (diff)
Added by Ori Rabin almost 6 years ago

Fixes #15308 - Override validation doesn't run without changes

Revision 2ecf3ff9 (diff)
Added by Ori Rabin almost 6 years ago

Fixes #15308 - Override validation doesn't run without changes

(cherry picked from commit 85c9be5a6ed9b593214cf3bc9de2f29960a2a25a)

History

#1 Updated by Dominic Cleal almost 6 years ago

  • Related to Bug #13727: Error not raised while setting default value when 'Override' set to False for parameter. added

#2 Updated by Dominic Cleal almost 6 years ago

  • Category set to Parameters
  • Legacy Backlogs Release (now unused) set to 136

#3 Updated by Ori Rabin almost 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Ori Rabin

#4 Updated by The Foreman Bot almost 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3573 added

#5 Updated by Tomer Brisker almost 6 years ago

  • Bugzilla link set to 1343378

#6 Updated by Tomer Brisker almost 6 years ago

note: this bug also prevents saving any smart class parameter without changes when viewing from the smart class parameter edit form.

#7 Updated by Tomer Brisker almost 6 years ago

This fails in the class view only for array/hash values with inactive matchers, since the lookup value is changed (this is before it is parsed back into a ruby object - so it changes from object to string), causing the nested attribute to have nested_records_changed_for_autosave? set to true, and thus running the validation on it.

#8 Updated by Ori Rabin almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF