Project

General

Profile

Bug #15420

full_results parameter is improperly defined in the API documentation

Added by Andrew Kofink over 2 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The discrepancy exists in spelling 'full_results' versus 'full_result'. This change will change the API.


Related issues

Related to Katello - Bug #15443: Use fully qualified object ::Foreman in #15420Closed2016-06-16

Associated revisions

Revision 49469e2e (diff)
Added by Andrew Kofink over 2 years ago

Fixes #15420 - Adjust full_results param (#6126)

While the API advertised a parameter named :full_results, our code was
expecting the param to be named :full_result. This change adds tests to
ensure the :full_results parameter can be used and is actually effective
in our system.

In addition, this changes the API parameter documented from
:full_results to :full_result

Furthermore, this parameter was failing to cast from a JSON string to a
boolean such that 'false', 'true', 0, or 1 would return a true value.
This introduces a proper cast using `Foreman::Cast.to_bool`.

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6126 added

#2 Updated by Anonymous over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Justin Sherrill over 2 years ago

  • Legacy Backlogs Release (now unused) set to 162

#4 Updated by Andrew Kofink over 2 years ago

  • Related to Bug #15443: Use fully qualified object ::Foreman in #15420 added

Also available in: Atom PDF