Project

General

Profile

Feature #15519

Speed up host editing when using vmware compute resource

Added by Alex Fisher about 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources - VMware
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Hi

Since the vmware properties are read-only after host creation, would it be possible to not automatically load them when editing a host?
Perhaps only load them after clicking on the 'virtual machine' tab? The vmware API is so slow and editing a host can be really painful.


Related issues

Related to Foreman - Tracker #18255: Speed up vmwareNew2017-01-26

Associated revisions

Revision 0d851b1d (diff)
Added by Timo Goebel almost 3 years ago

fixes #15519 - speed up host edit page rendering on vmware

This commit speeds up the rendering of the host edit page for hosts on
VMWare. The API calls to list networks and datastores are expensive.
When editing a host, these information is never showed to a user and
furthermore CR editing on VMWare is not supported.
So instead of displaying a select box, this commit shows a textbox.

History

#1 Updated by Dominic Cleal about 3 years ago

  • Category set to Compute resources - VMware

Some option to keep showing them is probably required, people do rely on it (we get bug reports when it's broken).

#2 Updated by Timo Goebel almost 3 years ago

  • Status changed from New to Assigned
  • Assignee set to Timo Goebel

The reason for this is that in the host edit views select boxes are rendered with all available volumes or networks. This is a very expensive call with VMWare. In addition, this is completely unnecessary as they are disabled the whole time.

Affected views:

app/views/compute_resources_vms/form/vmware/_network.html.erb
app/views/compute_resources_vms/form/vmware/_volume.html.erb

What they need:
<% if new_host >
<
end %>

#3 Updated by The Foreman Bot almost 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3964 added

#4 Updated by Timo Goebel almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 189

#6 Updated by Timo Goebel over 2 years ago

Also available in: Atom PDF