Refactor #15525: Fact-type specific host's last_compile time - Foreman

Refactor #15525

Fact-type specific host's last_compile time

Added by Ivan Necas over 4 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Stephen Benjamin

Category:

Facts

Target version:

1.12.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/3615

Fixed in Releases:

Found in Releases:

Description

The last_compile time is right now global. Which means:

1. importing facts of one type would prevent importing facts of another type (see http://projects.theforeman.org/issues/15524 for specific case), due to https://github.com/theforeman/foreman/blob/1.11.3/app/models/host/base.rb#L142
2. the time of the fact might be wrong https://github.com/theforeman/foreman/blob/1.11.3/app/helpers/fact_values_helper.rb#L3, as the last_compile time is used
to show time of the fact.

We should probably make the last_compile a type-specific type so that they don't interfere with each other.

Related issues

Associated revisions

Revision abdced07 (diff)
Added by Stephen Benjamin over 4 years ago

fixes #15525 - always update facts

Previously, last_compile was checked to see if facts were uploaded in
the last minute and if so, ignore processing them. This code dates back
to the very first tagged version of Foreman in git - but these days we
have multiple providers so this check doesn't make sense. It's quite
conceivable that Salt/Chef/Puppet/Subscription Manager could upload
facts within such a short window - in fact, it does happen during
provisioning.

Revision d4dd8139 (diff)
Added by Stephen Benjamin over 4 years ago

fixes #15525 - always update facts

(cherry picked from commit abdced078c280a72ee1992fbbfd29772d7fc1ce2)