Project

General

Profile

Bug #15583

sync status page is out of date when sync occurs via hammer, causing errors

Added by Chris Duryee almost 3 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

If you load the sync status page, then kick off a sync via hammer, you'll get a 500 error when starting a second sync via the page.

The stack is:

 | NameError (undefined local variable or method `notify' for #<Katello::SyncManagementController:0x0000000f612628>):
 |   katello (3.0.0.51) app/controllers/katello/sync_management_controller.rb:68:in `block in sync_repos'
 |   katello (3.0.0.51) app/controllers/katello/sync_management_controller.rb:63:in `sync_repos'
 |   katello (3.0.0.51) app/controllers/katello/sync_management_controller.rb:33:in `sync'
 |   app/controllers/concerns/application_shared.rb:13:in `set_timezone'
 |   lib/middleware/catch_json_parse_errors.rb:9:in `call'

Associated revisions

Revision 0f1101ee (diff)
Added by Chris Duryee almost 3 years ago

Fixes #15583: sync status page gets confused by other syncs

If you load the sync status page and then kick off a sync via other
means, a new sync kicked off via the page will result in error.

It looks like the defunct notification framework was still being used,
causing issues.

This patch simply finds the existing running sync if one exists, and
returns that in the sync status page.

Revision bf94e263
Added by Chris Duryee almost 3 years ago

Merge pull request #6169 from beav/sync-status

Fixes #15583: sync status page gets confused by other syncs

History

#1 Updated by The Foreman Bot almost 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6169 added

#2 Updated by Chris Duryee almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Justin Sherrill almost 3 years ago

  • Category set to Web UI
  • Legacy Backlogs Release (now unused) set to 143
  • Difficulty set to easy

Also available in: Atom PDF