Project

General

Profile

Bug #15692

Run hammer-cli-foreman tests with the hammer-cli-katello tests

Added by Andrew Kofink almost 3 years ago. Updated 11 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Hammer
Target version:
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Currently we run hammer-cli-foreman and hammer-cli-katello tests independent of each other.

Consider the `hammer hostgroups create` command, which exists in hammer-cli-foreman with an option `--environment`. When hammer-cli-katello extends the command to add options such as `--lifecycle-environment`, the `environment_id` resolver that was in HammerCLIForeman::IdResolver can now be overridden in the HammerCLIKatello::IdResolver, which inherits from HammerCLIForeman::IdResolver (as is the case with many Foreman extensions in Katello). If improperly overridden, the resolver creates failures in hammer-cli-foreman commands, even if Katello objects are not involved. For example, `--environment` may now fail to resolve properly and without errors.

The crux of the problem: we don't test strictly hammer-cli-foreman commands in hammer-cli-katello because we would be duplicating tests which are (or should be) already written in hammer-cli-foreman; however, hammer-cli-katello extensions on top of hammer-cli-foreman can break foreman-based commands. We need to install hammer-cli-katello but then run the hammer-cli-foreman test suite to ensure we didn't break any existing commands.

History

#1 Updated by Justin Sherrill almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 162

#2 Updated by John Mitsch almost 3 years ago

  • Legacy Backlogs Release (now unused) changed from 162 to 114

Also available in: Atom PDF