Project

General

Profile

Tracker #15715

Rails 5.0 upgrade tasks

Added by Dominic Cleal about 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
-
% Done:

0%

Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Track tasks to upgrade Foreman to support Rails 5.0.


Related issues

Related to Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Related to Foreman - Refactor #20956: Passing a class as a value in an Active Record query is deprecatedClosed2017-09-16
Related to Foreman - Refactor #20960: Use activerecord-session_store with Rails 5.1 compatibility Closed2017-09-16
Related to Foreman - Refactor #20961: Turbolinks Classic is not Rails 5.1 compatibleClosed2017-09-16
Related to Discovery - Bug #20970: Discovery via fact import is broken for rails 5Closed2017-09-17
Related to Discovery - Bug #20971: *_filter should be replaced with *_action for rails 5 compatClosed2017-09-17
Related to Foreman - Refactor #21084: Always use Rails 5.0, Drop Rails 4.2Closed2017-09-23
Related to Foreman - Refactor #21097: remove settings deprecated by Rails 5.0Closed2017-09-25
Related to Foreman - Refactor #21098: Update functional test request positional args to keywords Closed2017-09-25
Related to Foreman - Refactor #21099: Replace redirect_to :back with redirect_back Closed2017-09-25
Related to Foreman - Refactor #21100: Explicitly set DB migration compatibility to 4.2Closed2017-09-25
Related to Foreman - Refactor #21101: Pass 'parameterize' separator as kwarg Closed2017-09-25
Related to Foreman - Refactor #21102: Replace 'xhr' in tests with keyword argumentClosed2017-09-25
Related to Foreman - Refactor #21103: Replace 'false' AR callback results with explicit throwClosed2017-09-25
Related to Discovery - Refactor #21153: Passing conditions to destroy_all is deprecatedClosed2017-09-28
Related to Foreman Remote Execution - Refactor #21216: fix Rails 5.x deprecations that are still compatible with Rails 4.2Closed2017-10-05
Related to Discovery - Bug #21244: Remaining Rails 5 ugprade problems in discoveryClosed2017-10-09
Related to Foreman - Bug #21553: Application doesn't start when using Rails 5 DEBsClosed2017-11-01
Related to Foreman - Bug #21564: OAuth i.e. for proxy registration doesn't work with Rails 5Closed2017-11-02
Related to Foreman - Refactor #7570: set secret_key_base for rails 6.0 upgradeNew2014-09-22
Related to Foreman - Refactor #21902: Replace use_transactional_fixtures settingClosed2017-12-07
Related to Katello - Bug #20317: Rails 5 compatibilityClosed2017-07-17
Related to Foreman - Refactor #22152: move away from record_tag_helperNew2018-01-04
Related to Foreman - Refactor #22153: move away from rails-controller-testingNew2018-01-04
Related to Foreman - Refactor #24934: Rails 5.x default configuration migrationsNew
Blocked by Foreman - Tracker #13243: Rails 4.2 upgrade tasksResolved2016-01-15

Blocked by Foreman - Feature #3917: Add strong_parameters to foremanClosed2013-12-19
Blocked by Foreman - Refactor #15716: Update jquery-rails to 4.xRejected2016-07-18
Blocked by Foreman - Refactor #15787: Update shoulda-matchers to 3.xClosed2016-07-22
Blocked by Foreman - Refactor #19035: Refactor TopbarSweeper to remove rails-observer dependencyClosed2017-03-27
Blocked by Foreman - Feature #19050: Add support for running under Ruby on Rails 5.0Closed2017-03-28
Blocked by foreman-tasks - Feature #20756: Support ActiveJob Dynflow adapter for Rails5Closed2017-08-28
Blocked by Foreman - Bug #20920: Rails 5 causes error when server is trying to startClosed2017-09-14
Blocked by Foreman - Refactor #20949: Replace deprecated ActiveModel::Errors usageClosed2017-09-16
Blocked by Foreman - Refactor #20950: change 'uniq' to 'distinct' in ActiveRecord findersClosed2017-09-16
Blocked by Foreman - Refactor #20951: Replace render :text with :plainClosed2017-09-16
Blocked by Foreman - Refactor #20952: Replace Hash-related methods called on AC::Parameters Closed2017-09-16
Blocked by Foreman - Refactor #20953: Remove unnecessary argument to assert_nothing_raisedClosed2017-09-16
Blocked by Foreman - Refactor #20954: Accessing mime types via constants is deprecatedClosed2017-09-16
Blocked by Foreman - Refactor #20957: Replace alias_method_chain with Module prepend Closed2017-09-16
Blocked by Foreman - Refactor #20958: Passing an argument to force an association to reload is deprecatedClosed2017-09-16
Blocked by Foreman - Refactor #20959: Remove :status option on 'head' to positional argument Closed2017-09-16
Blocked by Foreman Remote Execution - Bug #20254: REX tests fail to run with rails 5Resolved2017-07-10
Blocked by Discovery - Bug #20972: STI issues with Host::Discovered on Rails 5Duplicate2017-09-17
Blocked by Foreman Remote Execution - Bug #20427: REX doesnt start with rails 5Closed2017-07-27
Blocked by foreman-tasks - Bug #20980: Tests are failing with rails 5Closed2017-09-18
Blocked by OpenSCAP - Bug #21094: Tests broken on Rails 5.0Closed2017-09-25

History

#1 Updated by Dominic Cleal about 3 years ago

#2 Updated by Dominic Cleal about 3 years ago

  • Blocked by Feature #3917: Add strong_parameters to foreman added

#3 Updated by Dominic Cleal about 3 years ago

#4 Updated by Ohad Levy about 3 years ago

I would love if we use this opportunity to move away to webpack assets vs rails asset pipeline.

#5 Updated by Daniel Lobato Garcia about 3 years ago

We're trying to, but what does Rails 5 have to do with it?


Reply from Ohad Levy:

Many of the asset ge,s are not compliant with rails 5 (e.g. wrong dependencies in spec file etc).
if we move away from using those, we wouldn't care much which version of rails we are using (and really, there is little connection between client side assets and rails version).


(Edited by Dominic, the comment was incorrectly edited instead of being replied to.)

#6 Updated by Michael Moll about 3 years ago

As a general hint: Rails 5 needs Ruby >= 2.2.1

#7 Updated by Dominic Cleal about 3 years ago

#8 Updated by Dominic Cleal over 2 years ago

  • Blocked by Refactor #19035: Refactor TopbarSweeper to remove rails-observer dependency added

#9 Updated by Dominic Cleal over 2 years ago

  • Blocked by Feature #19050: Add support for running under Ruby on Rails 5.0 added

#10 Updated by Lukas Zapletal over 2 years ago

  • Related to Bug #13772: The orchestration code uses SQL logger added

#11 Updated by Lukas Zapletal over 2 years ago

  • Related to deleted (Bug #13772: The orchestration code uses SQL logger)

#12 Updated by Michael Moll about 2 years ago

  • Status changed from New to Closed

#13 Updated by Tomer Brisker about 2 years ago

  • Status changed from Closed to New

Still not quite there, reopening.

#14 Updated by Tomer Brisker about 2 years ago

  • Related to Feature #20756: Support ActiveJob Dynflow adapter for Rails5 added

#15 Updated by Tomer Brisker about 2 years ago

  • Related to deleted (Feature #20756: Support ActiveJob Dynflow adapter for Rails5)

#16 Updated by Tomer Brisker about 2 years ago

  • Blocked by Bug #20317: Rails 5 compatibility added

#17 Updated by Tomer Brisker about 2 years ago

  • Blocked by Feature #20756: Support ActiveJob Dynflow adapter for Rails5 added

#18 Updated by Tomer Brisker about 2 years ago

  • Blocked by Bug #20920: Rails 5 causes error when server is trying to start added

#19 Updated by Michael Moll about 2 years ago

#20 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20949: Replace deprecated ActiveModel::Errors usage added

#21 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20950: change 'uniq' to 'distinct' in ActiveRecord finders added

#22 Updated by Michael Moll about 2 years ago

#23 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20952: Replace Hash-related methods called on AC::Parameters added

#24 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20953: Remove unnecessary argument to assert_nothing_raised added

#25 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20954: Accessing mime types via constants is deprecated added

#26 Updated by Michael Moll about 2 years ago

  • Related to Refactor #20956: Passing a class as a value in an Active Record query is deprecated added

#27 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20957: Replace alias_method_chain with Module prepend added

#28 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20958: Passing an argument to force an association to reload is deprecated added

#29 Updated by Michael Moll about 2 years ago

  • Blocked by Refactor #20959: Remove :status option on 'head' to positional argument added

#30 Updated by Michael Moll about 2 years ago

  • Related to Refactor #20960: Use activerecord-session_store with Rails 5.1 compatibility added

#31 Updated by Michael Moll about 2 years ago

  • Related to Refactor #20961: Turbolinks Classic is not Rails 5.1 compatible added

#32 Updated by Tomer Brisker about 2 years ago

  • Related to Bug #20970: Discovery via fact import is broken for rails 5 added

#33 Updated by Tomer Brisker about 2 years ago

  • Related to Bug #20971: *_filter should be replaced with *_action for rails 5 compat added

#34 Updated by Tomer Brisker about 2 years ago

  • Blocked by Bug #20254: REX tests fail to run with rails 5 added

#35 Updated by Tomer Brisker about 2 years ago

  • Blocked by Bug #20972: STI issues with Host::Discovered on Rails 5 added

#36 Updated by Tomer Brisker about 2 years ago

  • Blocked by Bug #20427: REX doesnt start with rails 5 added

#37 Updated by Adam Ruzicka about 2 years ago

  • Blocked by Bug #20980: Tests are failing with rails 5 added

#38 Updated by Michael Moll almost 2 years ago

#39 Updated by Marek Hulán almost 2 years ago

  • Blocked by Bug #21094: Tests broken on Rails 5.0 added

#40 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21097: remove settings deprecated by Rails 5.0 added

#41 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21098: Update functional test request positional args to keywords added

#42 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21099: Replace redirect_to :back with redirect_back added

#43 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21100: Explicitly set DB migration compatibility to 4.2 added

#44 Updated by Michael Moll almost 2 years ago

#45 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21102: Replace 'xhr' in tests with keyword argument added

#46 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21103: Replace 'false' AR callback results with explicit throw added

#47 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21153: Passing conditions to destroy_all is deprecated added

#48 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21216: fix Rails 5.x deprecations that are still compatible with Rails 4.2 added

#49 Updated by Lukas Zapletal almost 2 years ago

  • Related to Bug #21244: Remaining Rails 5 ugprade problems in discovery added

#50 Updated by Ivan Necas almost 2 years ago

  • Related to Refactor #21205: Replace alias_method_chain with Module prepend added

#51 Updated by Ivan Necas almost 2 years ago

  • Related to deleted (Refactor #21205: Replace alias_method_chain with Module prepend )

#52 Updated by Michael Moll almost 2 years ago

  • Related to Bug #21553: Application doesn't start when using Rails 5 DEBs added

#53 Updated by Michael Moll almost 2 years ago

  • Related to Bug #21564: OAuth i.e. for proxy registration doesn't work with Rails 5 added

#54 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #7570: set secret_key_base for rails 6.0 upgrade added

#55 Updated by Michael Moll almost 2 years ago

  • Related to Refactor #21902: Replace use_transactional_fixtures setting added

#56 Updated by Michael Moll almost 2 years ago

  • Blocked by deleted (Bug #20317: Rails 5 compatibility)

#57 Updated by Michael Moll almost 2 years ago

  • Related to Bug #20317: Rails 5 compatibility added

#58 Updated by Michael Moll almost 2 years ago

  • Status changed from New to Resolved

Rails 5.0 is in, further issues should connect to #20948 (Rails 5.1 upgrade)

#59 Updated by Michael Moll over 1 year ago

#60 Updated by Michael Moll over 1 year ago

  • Related to Refactor #22153: move away from rails-controller-testing added

#61 Updated by Michael Moll about 1 year ago

  • Related to Refactor #24934: Rails 5.x default configuration migrations added

Also available in: Atom PDF