Project

General

Profile

Actions

Bug #15718

closed

Hashes defined in matchers do not save properly after the first time

Added by Gerard van Dijnsen over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When opening a class that contains a matcher that has a hash in a value field, the class can not be properly submitted. The hash is changed from json format into a normal ruby hash (valid as far as I can see). Saving of the class then fails with a 'JSON::ParserError: 795: unexpected token' error in the production.log.


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #13244: Upgrade Ruby on Rails to 4.2ClosedDominic Cleal01/15/2016Actions
Actions #1

Updated by Dominic Cleal over 7 years ago

  • Category set to Parameters
  • translation missing: en.field_release set to 161

Confirmed, this is a regression in 1.12.0. Rails now only calls value_before_type_cast (which contains the user YAML/JSON input) when rendering the tag if "value_came_from_user?" returns true too: https://github.com/rails/rails/commit/3e74db6

This causes Rails to use #value to render the tag which contains the Ruby hash.

Actions #2

Updated by Dominic Cleal over 7 years ago

Actions #3

Updated by Tomer Brisker over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomer Brisker
Actions #4

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3658 added
Actions #5

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF