Project

General

Profile

Actions

Bug #15719

closed

The upgrade script doesn't check on successful installer run

Added by Ivan Necas over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Upgrades
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1356961

Description of problem:

Since we don't check if the puppet run was successful, there can be cases
where the installer fails really badly (such as validation error above),
but we continue and get furhter issues due to incomplete setup.

 [ERROR 2016-07-16 04:41:16 main]  "dhcp209-249.gsslab.pnq.redhat.com.crt" is not an absolute path. at /usr/share/katello-installer-base/modules/certs/manifests/init.pp:115 on node dhcp209-249.gsslab.pnq.redhat.com
 [ INFO 2016-07-16 04:41:16 main] /usr/share/foreman-installer/modules/stdlib/lib/puppet/parser/functions/validate_absolute_path.rb:46:in `block (3 levels) in <module:Functions>'
 [ INFO 2016-07-16 04:41:16 main] /usr/share/foreman-installer/modules/stdlib/lib/puppet/parser/functions/validate_absolute_path.rb:44:in `each'
 [ INFO 2016-07-16 04:41:16 main] /usr/share/foreman-installer/modules/stdlib/lib/puppet/parser/functions/validate_absolute_path.rb:44:in `block (2 levels) in <module:Functions>'
 [ INFO 2016-07-16 04:41:16 main] /usr/share/foreman-installer/modules/stdlib/lib/puppet/parser/functions/validate_absolute_path.rb:35:in `each'
 [ INFO 2016-07-16 04:41:16 main] /usr/share/foreman-installer/modules/stdlib/lib/puppet/parser/functions/validate_absolute_path.rb:35:in `block in <module:Functions>'
 [ INFO 2016-07-16 04:41:16 main] /usr/share/ruby/vendor_ruby/puppet/parser/functions.rb:164:in `block (2 levels) in newfunction'
 [ INFO 2016-07-16 04:41:16 main] /usr/share/ruby/vendor_ruby/puppet/util/profiler/around_profiler.rb:58:in `profile'

 [...]

 Upgrade Step: Running installer...
 Preparing installation Done                                              
   Something went wrong! Check the log for ERROR-level output
   The full log is at /var/log/foreman-installer/satellite.log
 Upgrade Step: restart_services...
 .
 .
 .
 Success!

 Upgrade Step: db_seed...
 rake aborted!
 Errno::ENOENT: No such file or directory @ rb_sysopen - /etc/pki/katello/certs/pulp-client.crt
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/app/services/cert/certs.rb:12:in `initialize'
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/app/services/cert/certs.rb:12:in `open'
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/app/services/cert/certs.rb:12:in `ssl_client_cert'
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/app/services/katello/pulp/server.rb:28:in `config'
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/config/initializers/runcible.rb:3:in `pulp_server'
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/app/models/katello/glue/pulp/repo.rb:29:in `ensure_sync_notification'
 /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/108-ensure_sync_notification.rb:9:in `<top (required)>'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:241:in `load'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:241:in `block in load'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:232:in `load_dependency'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:241:in `load'
 /usr/share/foreman/db/seeds.rb:81:in `block in <top (required)>'
 /usr/share/foreman/db/seeds.rb:79:in `each'
 /usr/share/foreman/db/seeds.rb:79:in `<top (required)>'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:241:in `load'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:241:in `block in load'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:232:in `load_dependency'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:241:in `load'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/railties-4.1.5/lib/rails/engine.rb:543:in `load_seed'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activerecord-4.1.5/lib/active_record/tasks/database_tasks.rb:184:in `load_seed'
 /opt/rh/rh-ror41/root/usr/share/gems/gems/activerecord-4.1.5/lib/active_record/railties/databases.rake:173:in `block (2 levels) in <top (required)>'
 Tasks: TOP => db:seed
 (See full trace by running task with --trace)
 Seeding /usr/share/foreman/db/seeds.d/03-auth_sources.rb
 Seeding /usr/share/foreman/db/seeds.d/03-permissions.rb
 Seeding /usr/share/foreman/db/seeds.d/03-roles.rb
 Seeding /usr/share/foreman/db/seeds.d/04-admin.rb
 Seeding /usr/share/foreman/db/seeds.d/05-taxonomies.rb
 Seeding /usr/share/foreman/db/seeds.d/06-architectures.rb
 Seeding /usr/share/foreman/db/seeds.d/07-provisioning_templates.rb
 Seeding /usr/share/foreman/db/seeds.d/08-partition_tables.rb
 Seeding /usr/share/foreman/db/seeds.d/10-installation_media.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/101-locations.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/102-organizations.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/103-provisioning_templates.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/104-proxy.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/106-mail_notifications.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/107-enable_dynflow.rb
 Seeding /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.61/db/seeds.d/108-ensure_sync_notification.rb

 Upgrade step db_seed failed. Check logs for more information.
 
Actions #1

Updated by Ivan Necas over 7 years ago

  • Subject changed from The upgrade script doesn't check on successful installer run to The upgrade script doesn't check on successful installer run
  • Description updated (diff)
Actions #2

Updated by Ivan Necas over 7 years ago

  • Priority changed from Urgent to High
Actions #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • Pull request https://github.com/Katello/katello-installer/pull/376 added
Actions #4

Updated by Ivan Necas over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Justin Sherrill over 7 years ago

  • translation missing: en.field_release set to 143
Actions

Also available in: Atom PDF