Project

General

Profile

Refactor #15720

Replace *_filter in controllers with *_action

Added by Dominic Cleal about 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Rails 5.0 deprecations the before/after_filter type helpers in controllers in favour of *_action replacements. The name simply needs changing.

Rubocop also provides a currently disabled cop to enforce the newer syntax that can be enabled.


Related issues

Related to Katello - Refactor #15722: rename *_filter to *_actionClosed2016-07-18

Associated revisions

Revision df6a9f34 (diff)
Added by Dominic Cleal about 4 years ago

fixes #15720 - rename *_filter to *_action

The older 'filter' name is changing in Rails to 'action' and is being
deprecated.

History

#1 Updated by The Foreman Bot about 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3657 added

#2 Updated by David Davis about 4 years ago

#3 Updated by Dominic Cleal about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal about 4 years ago

  • Legacy Backlogs Release (now unused) set to 160

Also available in: Atom PDF