Project

General

Profile

Actions
Copy link

Refactor #15720

closed

Replace *_filter in controllers with *_action

Added by Dominic Cleal about 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Dominic Cleal
Category:
Rails
Target version:
1.13.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3657
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Rails 5.0 deprecations the before/after_filter type helpers in controllers in favour of *_action replacements. The name simply needs changing.

Rubocop also provides a currently disabled cop to enforce the newer syntax that can be enabled.

Related issues 1 (0 open — 1 closed)

Related to Katello - Refactor #15722: rename *_filter to *_actionClosedDavid Davis07/18/2016Actions
Actions
Copy link
 #1

Updated by The Foreman Bot about 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3657 added
Actions
Copy link
 #2

Updated by David Davis about 8 years ago

Actions
Copy link
 #3

Updated by Dominic Cleal about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Dominic Cleal about 8 years ago

  • Translation missing: en.field_release set to 160
Actions
Copy link

Also available in: Atom PDF