Bug #15728: Test fails with new json release (2.0) which fixes parse error - Runcible - Foreman

Actions

Copy link

Bug #15728

open

Test fails with new json release (2.0) which fixes parse error

Added by David Davis over 8 years ago. Updated over 7 years ago.

Status:

New

Priority:

Normal

Assignee:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/Katello/runcible/pull/180

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The test uses 'true' as the response body which is now valid json in the 2.0 version of the ruby json gem. It raised a parse error before which was actually in correct.

Here's the test failure:

  1) Error:
Base::TestBase#test_process_response_returns_string:
RuntimeError: can't modify frozen TrueClass
    /home/vagrant/.rvm/gems/ruby-2.2.4/gems/rest-client-1.8.0/lib/restclient/abstract_response.rb:27:in `response_set_vars'
    /home/vagrant/.rvm/gems/ruby-2.2.4/gems/rest-client-1.8.0/lib/restclient/response.rb:16:in `create'
    /home/vagrant/Projects/runcible/lib/runcible/base.rb:147:in `rest_client_response'
    /home/vagrant/Projects/runcible/lib/runcible/base.rb:135:in `process_response'
    test/unit/base_test.rb:38:in `test_process_response_returns_string'