Project

General

Profile

Actions
Copy link

Feature #15741

closed

Use parameter_filter instead of attr_accessible

Added by David Davis over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
David Davis
Category:
API
Target version:
Katello 3.2.0
Difficulty:
hard
Triaged:
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/6194
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Foreman is dropping support for protected_attributes and we need to switch to their new way of whitelisting attributes. See here for more info:

http://projects.theforeman.org/projects/foreman/wiki/Strong_parameters#Changing-core-extensions-to-use-the-plugin-API

Here's the Foreman PR:

https://github.com/theforeman/foreman/pull/3659

Related issues 3 (0 open — 3 closed)

Related to Foreman - Feature #3917: Add strong_parameters to foremanClosedDominic Cleal12/19/2013Actions
Has duplicate Katello - Bug #5158: Remove attr_accessible from KatelloDuplicate04/11/2014Actions
Has duplicate Katello - Bug #16109: db_seed fails with Host::Managed is using attr_accessible so must either be converted to strong parameters, or add the protected_attributes gemDuplicate08/15/2016Actions
Actions
Copy link
 #1

Updated by David Davis over 8 years ago

  • Project changed from Foreman to Katello
Actions
Copy link
 #2

Updated by David Davis over 8 years ago

  • Category changed from API to API
Actions
Copy link
 #3

Updated by David Davis over 8 years ago

  • Related to Bug #3659: "no implicit conversion of URI::HTTP into String" running rake reports:summarize added
Actions
Copy link
 #4

Updated by David Davis over 8 years ago

  • Related to deleted (Bug #3659: "no implicit conversion of URI::HTTP into String" running rake reports:summarize)
Actions
Copy link
 #5

Updated by David Davis over 8 years ago

  • Related to Feature #3917: Add strong_parameters to foreman added
Actions
Copy link
 #6

Updated by David Davis over 8 years ago

  • Assignee deleted (David Davis)
Actions
Copy link
 #7

Updated by David Davis over 8 years ago

One option would be to add protected_attributes as a dependency for Katello but I'd probably recommend against it. We use strong_params pretty much everywhere--except when extending the foreman models. We call attr_accessible in about 8 places that I think we can switch over to parameter_filter. I am going to investigate that route.

Actions
Copy link
 #8

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to David Davis
  • Pull request https://github.com/Katello/katello/pull/6194 added
Actions
Copy link
 #9

Updated by David Davis over 8 years ago

  • Has duplicate Bug #5158: Remove attr_accessible from Katello added
Actions
Copy link
 #10

Updated by Justin Sherrill over 8 years ago

  • Translation missing: en.field_release set to 162
  • Difficulty set to hard
Actions
Copy link
 #11

Updated by Anonymous over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by David Davis over 8 years ago

  • Has duplicate Bug #16109: db_seed fails with Host::Managed is using attr_accessible so must either be converted to strong parameters, or add the protected_attributes gem added
Actions
Copy link

Also available in: Atom PDF