Project

General

Profile

Refactor #15787

Update shoulda-matchers to 3.x

Added by Dominic Cleal about 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The shoulda-matchers gem should be updated to the 3.x series. More information is available at https://robots.thoughtbot.com/shoulda-matchers-3-0, including changes to initial configuration.


Related issues

Related to Foreman - Refactor #26607: Update shoulda-matchers to 4.xClosed
Blocks Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Associated revisions

Revision 295536d1 (diff)
Added by Dominic Cleal almost 4 years ago

fixes #15787 - update shoulda-matchers to 3.x

Contains changes to models for the new behaviour of the uniqueness
validation test, which saves a model with one value and then attempts
to validate a second.

NestedAncestryCommon's validation now doesn't fail when the specified
ancestry/parent_id is non-existent (shoulda-matchers generates an
invalid value).

Validations of title on NestedAncestryCommon models have been removed
as it's derived automatically from the name field, and can't be tested
independently of the model name. This in any case was a duplicate
validation of the name which is scoped to ancestry.

Host::Base has #dup implemented so the copied model has a valid primary
interface for #name= to work, matching the behaviour of #initialize.

History

#1 Updated by Dominic Cleal about 4 years ago

#2 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Dominic Cleal
  • Pull request https://github.com/theforeman/foreman/pull/3676 added

#3 Updated by Dominic Cleal almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 160

#5 Updated by Anonymous over 1 year ago

Also available in: Atom PDF