Project

General

Profile

Actions
Copy link

Bug #15940

closed

Package upload action logs whole input as Parameters

Added by Lukas Zapletal over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Justin Sherrill
Category:
Subscriptions
Target version:
Katello 3.2.0
Difficulty:
easy
Triaged:
Bugzilla link:
1429642
Pull request:
https://github.com/Katello/katello/pull/6264
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Rails logs all incoming parameters via INFO logger by default (no opt-out).

Package upload request can be huge JSON and it does not make sense to log everything.

Rails provide parameter filters to filter out sensitive data from these (e.g. passwords), the action could perhaps use this to opt-out logging of the whole root data (_json key).

Actions
Copy link
 #1

Updated by Justin Sherrill over 8 years ago

  • Assignee set to Justin Sherrill
  • Translation missing: en.field_release set to 162
  • Difficulty set to easy
Actions
Copy link
 #2

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6264 added
Actions
Copy link
 #3

Updated by Brad Buckingham over 8 years ago

  • Target version set to 123
Actions
Copy link
 #4

Updated by Justin Sherrill over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Chris Duryee about 8 years ago

  • Bugzilla link set to 1429642
Actions
Copy link

Also available in: Atom PDF