Bug #16014: Improve error message when media is not set properly - Katello - Foreman

Actions

Copy link

Bug #16014

open

Improve error message when media is not set properly

Added by Lukas Zapletal over 7 years ago. Updated almost 6 years ago.

Status:

New

Priority:

Normal

Assignee:

Category:

Content Views

Target version:

Katello Backlog

Difficulty:

trivial

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

When media is not set or not available via taxonomy, we generate error trace:

2016-08-05 12:28:16 [app] [W] Fetch TFTP boot files for mac52540028624f.lab.eng.rdu2.redhat.com task failed with the following error: undefined method `path' for nil:NilClass
 | NoMethodError: undefined method `path' for nil:NilClass
 | /usr/share/foreman/app/models/operatingsystem.rb:121:in `medium_uri'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.69/app/models/katello/concerns/redhat_extensions.rb:52:in `medium_uri_with_content_uri'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.69/app/models/katello/concerns/redhat_extensions.rb:86:in `block in boot_files_uri_with_content'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.69/app/models/katello/concerns/redhat_extensions.rb:85:in `collect'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.0.0.69/app/models/katello/concerns/redhat_extensions.rb:85:in `boot_files_uri_with_content'
 | /usr/share/foreman/app/models/operatingsystem.rb:183:in `pxe_files'
 | /usr/share/foreman/app/models/concerns/orchestration/tftp.rb:78:in `setTFTPBootFiles'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:162:in `execute'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:107:in `block in process'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:99:in `each'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:99:in `process'
 | /usr/share/foreman/app/models/concerns/orchestration.rb:35:in `on_save'

We should catch for exceptions in the orchestration code and issue error.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Lukas Zapletal over 7 years ago

We need to check for StandardError in the setTFTPBootFiles method.

Actions

Copy link

Updated by Lukas Zapletal over 7 years ago

When doing this, put an ERF entry on our wiki with explanation of the error.

Actions

Copy link

Updated by Marek Hulán over 7 years ago

Category set to Orchestration

Actions

Copy link

Updated by Dominic Cleal over 7 years ago

Related to Feature #15439: Improve invalid medium error added

Actions

Copy link

Updated by Dominic Cleal over 7 years ago

Project changed from Foreman to Katello
Category deleted (~~Orchestration~~)

This is already implemented in boot_files_uri in #15439, but the stack trace above looks like the issue is introduced by Katello which is not deferring to the original boot_files_uri method containing the safety checks.

I'd suggest whatever checks are in Foreman should be applied to Katello, or it should call, not override, the original method.

Actions

Copy link