Bug #16081
Facts page in core expects .host relation
Status:
Closed
Priority:
Normal
Assignee:
Category:
Discovery plugin
Target version:
Difficulty:
Triaged:
No
Description
The /fact_values page in Foreman has a helper that expects fact_value.host at several places:
https://github.com/theforeman/foreman/blob/develop/app/helpers/fact_values_helper.rb#L18
https://github.com/theforeman/foreman/blob/develop/app/helpers/fact_values_helper.rb#L29
However, fact values for discovered hosts will not respond to that method.
You can call fact_value.host_id just fine, but not fact_value.host.
That causes a 500 on any /fact_values page that needs to show discovered hosts facts
Related issues
Associated revisions
History
#1
Updated by Daniel Lobato Garcia over 6 years ago
Updated by - Related to Bug #16082: FactValue association to Host should be against Host::Base added
#2
Updated by The Foreman Bot over 6 years ago
Updated by - Status changed from New to Ready For Testing
- Assignee set to Daniel Lobato Garcia
- Pull request https://github.com/theforeman/foreman_discovery/pull/294 added
#3
Updated by Daniel Lobato Garcia over 6 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman_discovery|f91555774b4856492ffa262a12749882906217bc.
Fixes #16081 - FactValue returns value for .host
The /fact_values page in Foreman has a helper that expects
fact_value.host at several places:
app/helpers/fact_values_helper.rb#L18
app/helpers/fact_values_helper.rb#L29
However, fact values for discovered hosts will not respond to that
method.
You can call fact_value.host_id just fine, but not fact_value.host.
That causes a 500 on any /fact_values page that needs to show discovered
hosts facts