Project

General

Profile

Actions

Refactor #16140

open

Register ISC inotify leases watcher on leases file only, not directory

Added by Dominic Cleal over 8 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
DHCP
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The ISC inotify leases watcher currently adds a :modify watcher on the entire parent directory, but should instead register it only on the target inode.

When the file is recreated, the old watcher needs to be closed and re-registered. In rb-inotify 0.9.7, this may result in an exception when an event's received for the old watcher - this is fixed in https://github.com/nex3/rb-inotify/commit/a3ff7cc in master. Once released, this could be implemented.

Example implementation: https://github.com/theforeman/smart-proxy/compare/develop...domcleal:16021-inotify-queue-overflow-reregister


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Bug #16021: inotify queue overflow halts ISC lease file monitoringClosedDominic Cleal08/09/2016Actions
Actions

Also available in: Atom PDF