Project

General

Profile

Feature #16200

Support module namespacing for on-complete callback

Added by Ondřej Pražák over 2 years ago. Updated over 2 years ago.

Status:
Rejected
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

bundle.js requires newly added js modules and makes them available through Webpack. Unfortunately, on-complete callback (https://github.com/theforeman/foreman/blob/develop/app/assets/javascripts/application.js#L103) does not support modules because window['a.b.c'] !== window['a']['b']['c']. Backward compatible support for module namespaces should be introduced for this callback.

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3751 added

#2 Updated by Dominic Cleal over 2 years ago

  • Status changed from Ready For Testing to Rejected

PR closed in favour of changes in #13047.

Also available in: Atom PDF