Project

General

Profile

Bug #16209

calling `enabled_repos` always forces an errata applicability regeneration

Added by Chris Duryee almost 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Client/Agent
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

If you restart goferd on a system, errata applicability will be regenerated. This can cause performance issues, especially if you have a large number of hosts.

How reproducible: every time

Steps to Reproduce:
1. register host to Katello, ensure goferd is running
2. restart goferd
3. check tasks list

Actual results: applicability regeneration task is created

Expected results: applicability regeneration should only happen when list of enabled repos changes

Additional info: the task list is the "true" way to check this, but a quick way is to tail /var/log/httpd/foreman-ssl_access_ssl.log on the server and restart goferd on the client. If you see a line like "POST /pulp/api/v2/consumers/actions/content/regenerate_applicability//", it means a regenerate was fired.

Associated revisions

Revision 184c966c (diff)
Added by Chris Duryee almost 3 years ago

Fixes #16209 - do not regenerate applicability if nothing changed

Previously, POSTing to `enabled_repos` from a client would always
result in an applicability generation task running, even if the list of
repos sent up was identical to what Katello already had stored locally.
This caused performance issues, especially if clients were being
restarted.

Instead, only kick off an applicability generation if the repo list is
altered.

Revision a569ea2f
Added by Chris Duryee almost 3 years ago

Merge pull request #6271 from beav/16209

Fixes #16209 - do not regenerate applicability if nothing changed

History

#1 Updated by Chris Duryee almost 3 years ago

  • Bugzilla link set to 1368746

#2 Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6271 added

#3 Updated by Chris Duryee almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Justin Sherrill almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 162

Also available in: Atom PDF