Project

General

Profile

Feature #16222

Make Hound run ESLint on new JS

Added by Daniel Lobato Garcia almost 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:

Description

#15806 adds support for ESLint on new JS code via 'npm run lint' . We can make houndCI run these tests on every PR fairly easily


Related issues

Follows Foreman - Feature #15806: Add eslint to foremanClosed

Associated revisions

Revision da6a1676 (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #16222 - Make HoundCI round ESLint on new JS

15806 adds support for ESLint on new JS code via 'npm run lint'
This contains the configuration to make HoundCI run these linting checks
and comment on the pull request with any warnings. It'll ignore the old
javascript in app/assets/javascript

Revision f233e57d (diff)
Added by Tomer Brisker almost 4 years ago

Refs #16222 - Increase scope of eslint ignore

Revision aa847c7c (diff)
Added by Tomer Brisker almost 4 years ago

Refs #16222 - remove no-global-assign rule from eslint

Hound uses an older version of eslint that does not support this rule
leading to confusing comments on PRs. The rule is not crucial and can be
removed.

Revision dd57843d
Added by Ohad Levy almost 4 years ago

Refs #16222 - remove no-global-assign rule from eslint (#3787)

Hound uses an older version of eslint that does not support this rule
leading to confusing comments on PRs. The rule is not crucial and can be
removed.

History

#1 Updated by Daniel Lobato Garcia almost 4 years ago

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3761 added

#3 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 160

#5 Updated by Daniel Lobato Garcia almost 4 years ago

  • Target version set to 1.6.2

#6 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3776 added

#7 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3787 added

Also available in: Atom PDF