Project

General

Profile

Refactor #16288

Move ace editor from bundle to npm

Added by Tomer Brisker about 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ohad Levy
Category:
Web Interface
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4392
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Task #23451: move all javascript/css assets to webpackNew2018-04-30
Blocks Foreman - Task #16283: Move all vendored assets and asset gems to npm+webpackNew2016-08-25

Associated revisions

Revision 71f05b78 (diff)
Added by Ohad Levy over 3 years ago

fixes #16288 - moves ace editor to webpack.

I've tried to limit changes to minimum, besides fixing lint errors i've:
- moved to brace package (as its compatable with br and webpack).
- added ERB as a syntex highlight.

Revision 7566ceeb (diff)
Added by Dominic Cleal over 3 years ago

refs #16288 - require nodejs-brace

History

#1 Updated by Tomer Brisker about 4 years ago

  • Blocks Task #16283: Move all vendored assets and asset gems to npm+webpack added

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/4392 added

#3 Updated by Ohad Levy over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ohad Levy over 3 years ago

  • Legacy Backlogs Release (now unused) set to 209

#5 Updated by Ohad Levy over 2 years ago

  • Related to Task #23451: move all javascript/css assets to webpack added

Also available in: Atom PDF