Project

General

Profile

Feature #16417

Turning off create_new_host_when_facts_are_uploaded breaks discovery

Added by Susanne Bachmann almost 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Discovery plugin
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

i hope i can explain my problem so everyone can understand.

We have a external puppetmaster in our environment and want to receive facts and reports from then. This external puppetmaster managed more hosts than our foreman.
So we set the value:
settings - auth - trusted puppetmaster hosts - <out puppetmaster server>
settings - puppet - Create new host when facts are uploaded - false
settings - puppet - Create new host when report is uploaded - false

First i think all processes works fine. Until i want to discover a server over foreman_discovery plugin.

The discovered hosts show up under hosts - discovered hosts. But no facts are there. So i can't provision the hosts.

After a while i change the setting:
settings - puppet - Create new host when facts are uploaded - true
So now the discovered Hosts will show up with the facts and can be provisioned.

So in our environment it would be nice to have the ability to exclude puppet from creating hosts from facts/reports. But the Discovery Plugin should be allowed to do this. Also it is a little bit confusing that the option under puppet is a global setting, not only for the puppet part...

Regards

Susanne


Related issues

Related to Foreman - Refactor #16424: Extract create_new_host_when_facts_are_uploaded into method of hostClosed2016-09-02

History

#1 Updated by Dominic Cleal almost 5 years ago

  • Project changed from Foreman to Discovery
  • Category set to Discovery plugin

#2 Updated by Lukas Zapletal almost 5 years ago

  • Subject changed from New Fact Upload should not always create a new Host to Turning off create_new_host_when_facts_are_uploaded breaks discovery

Thanks for report, this is because Discovery shares a lot of code from Foreman core at the moment. I agree this is confusing. The relevant setting is 'create_new_host_when_facts_are_uploaded', the other one does not change anything.

#3 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/3808 added

#4 Updated by Lukas Zapletal almost 5 years ago

  • Related to Refactor #16424: Extract create_new_host_when_facts_are_uploaded into method of host added

#5 Updated by Marek Hulán almost 5 years ago

Lukas, is there something else needed? The linked PR seems to be merged already. I think we should either unlink the PR an reset to New or close this.

#6 Updated by Susanne Bachmann about 4 years ago

Tested in 13.2 and works great.

#7 Updated by Lukas Zapletal about 4 years ago

  • Status changed from Ready For Testing to Closed

Yeah resolved, bot was not up perhaps?

Also available in: Atom PDF