Project

General

Profile

Bug #16462

Strong params breaks category selection in job invocation form

Added by Marek Hulán almost 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I'm unable to select job category.

Steps to reproduce
1. go to new job invocation form
2. select some job category
3. nothing happens, you can find 500 as a result of ajax call and following trace in the log

 | ActiveModel::ForbiddenAttributesError (ActiveModel::ForbiddenAttributesError):
 |   /home/ares/Projekty/Zdrojaky/foreman-tasks/app/models/foreman_tasks/triggering.rb:42:in `new_from_params'
 |   /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/models/job_invocation_composer.rb:461:in `build_triggering'
 |   /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/models/job_invocation_composer.rb:291:in `compose'
 |   /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/models/job_invocation_composer.rb:265:in `initialize'
 |   /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/models/job_invocation_composer.rb:276:in `new'
 |   /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/models/job_invocation_composer.rb:276:in `from_ui_params'
 |   /home/ares/Projekty/Zdrojaky/foreman_remote_execution/app/controllers/job_invocations_controller.rb:61:in `refresh'
 |   app/controllers/concerns/application_shared.rb:14:in `set_timezone'
 |   app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
 |   lib/middleware/catch_json_parse_errors.rb:9:in `call'
 |   lib/middleware/tagged_logging.rb:18:in `call'

Associated revisions

Revision dbe66c87 (diff)
Added by Ivan Necas almost 6 years ago

Fixes #16462 - fix strong params in job invocations (#204)

History

#1 Updated by Marek Hulán almost 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/204 added

#2 Updated by Ivan Necas almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Marek Hulán almost 6 years ago

  • Legacy Backlogs Release (now unused) deleted (179)

actually it will be in 1.1.1 which does not exist in redmine atm

Also available in: Atom PDF