Plugins » Katello

Proposed solution:

• change -m to limit per size (5000kB by default - subject to change the value)
• change add_files to traverse through files in argument from newest to oldest and capture whole files, until the size limit is reached
• added add_files_types method: this extends foreman-debug "API" to help collecting multiple types of logs in the same directory. E.g. /var/log/foreman contains multiple types of logs ( production.log*, cron.log* etc. where the "collect 5MB newest files" limit must be applied to them separately. One could call add_files to each such type individually (and maintain such a list whenever new log type is added), or call:
  

  add_files_types "[.]log" /var/log/foreman/*.log*
  

  
  that will find all unique prefixes of log filenames (i.e. production or cron) and will call add_files to them separatelly.

This change might break collecting complete (config) files if they are over the size limit (i.e. if add_files is called to a set of (config) files consuming more than 5MB disk space). I don't expect this to happen, but worth reviewing this.

In the pending PR, I replaced add_files by add_files_types whenever I understood all log types need to be collected. I am not sure if the same should be done for add_files /var/log/splice/* in katello-debug.sh since I dont know what logfiles can appear there.

The default limit 5MB (5000kB, checked by du -k) per add_files call is just first proposal. In my case, it caused bigger archive was generated than before, but lowering the value too much might cause only logs from insufficient past history are collected - the value is a subject of discussion and testing, surely.

• theforeman/foreman (for foreman-debug itself) - https://github.com/theforeman/foreman/pull/3881
• theforeman/smart-proxy (for foreman-debug-proxy) - https://github.com/theforeman/smart-proxy/pull/461
• katello/katello-packaging (for katello-debug.sh) - https://github.com/Katello/katello-packaging/pull/297