Project

General

Profile

Bug #16733

katello allows exporting of non-yum repos, resulting in error

Added by Chris Duryee over 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Inter Server Sync
Target version:
Difficulty:
trivial
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

ISS currently only supports yum repository export. However, currently this is not enforced by the controller, and the action will eventually raise a cryptic error about repo directories.

For example:

# hammer repository export --id 10
[.........................................................................................................................................................................................................] [100%]
unknown file type: /var/lib/pulp/published/yum/master/group_export_distributor/default_organization-docker-busybox

Repo export of non-yum repos should raise an error before the action is started.

Associated revisions

Revision c43e1e68 (diff)
Added by Chris Duryee over 2 years ago

Fixes #16733: raise useful error when exporting non-yum repo (#6360)

ISS currently only supports exporting yum repositories. However, this
was not enforced by the controller, and if you attempted to export a
repo that was not yum, you would get a baffling error message in the
action.

This patch checks that the repo is the correct type before exporting,
and raises a 400 error if not.

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6360 added

#2 Updated by Chris Duryee over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Justin Sherrill over 2 years ago

  • Legacy Backlogs Release (now unused) set to 162
  • Difficulty set to trivial

Also available in: Atom PDF