Refactor #16752

Extract template-related code from Host::Managed

Added by Daniel Lobato Garcia almost 2 years ago. Updated 10 days ago.

Status:Closed
Priority:Normal
Assignee:Daniel Lobato Garcia
Category:Rails
Target version:1.15.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/foreman/pull/3905

Description

Host::Managed contains a lot of code related with determining the template that a host should have. Other Host objects such as Host::Discovered might need that logic, without becoming a Host::Managed. A solution for this would be to extract the methods that have to do with templates to a concern, and every Host class that wants to implement them, just includes that concern.


Related issues

Related to Foreman - Bug #18557: Image based provisioning broken Resolved 02/18/2017

Associated revisions

Revision ec3360d9
Added by Daniel Lobato Garcia over 1 year ago

Fixes #16752 - Extract template code from Host::Managed

Host::Managed contains a lot of code related with determining the
template that a host should have. Other Host objects such as
Host::Discovered might need that logic, without becoming a
Host::Managed.

This commit extracts that into Hostext::OperatingSystem so it can
be used on plugins.

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3905 added

#2 Updated by Daniel Lobato Garcia almost 2 years ago

  • Target version set to 1.5.2

#3 Updated by Anonymous over 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 1 year ago

  • Category set to Rails
  • Legacy Backlogs Release (now unused) set to 209

#5 Updated by Daniel Lobato Garcia over 1 year ago

  • Target version changed from 1.5.2 to 169

#6 Updated by Brad Buckingham over 1 year ago

  • Target version deleted (169)

#7 Updated by Michael Moll over 1 year ago

  • Related to Bug #18557: Image based provisioning broken added

#8 Updated by Daniel Lobato Garcia over 1 year ago

  • Target version set to 1.11.0

Also available in: Atom PDF