Bug #16806
foreman_url template macro can't be used outside controller context
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assigned To: |  Marek Hulán | ||
| Category: | Templates | ||
| Target version: | Team Marek Iteration 4 | ||
| Difficulty: | Bugzilla link: | 1374344 | |
| Found in release: | Pull request: | https://github.com/theforeman/foreman/pull/3919 | |
| Story points | - | ||
| Velocity based estimate | - | ||
| Release | 1.14.0 | Release relationship | Auto |
Description
When foreman_url is used in a template which is rendered out of controller context it fails with url_for. I'm afraid it's not reproducible with pure Foreman atm but the Renderer should include url helpers so once it's included, all it's macros can be used. The issue is easily reproducible from remote execution plugin, when foreman_url is put in job template and then previewed.
Related issues
Associated revisions
Fixes #16806 - include renderer url dependencies
History
#1
Updated by Marek Hulán over 1 year ago
- Subject changed from foreman_url template macro can't be used outside controller context to foreman_url template macro can't be used outside controller context
- Category set to Templates
- Status changed from New to Assigned
- Assigned To set to Marek Hulán
- Priority changed from High to Normal
#2
Updated by The Foreman Bot over 1 year ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3919 added
#3
Updated by Marek Hulán over 1 year ago
- Target version set to Team Marek Iteration 4
#4
Updated by Marek Hulán over 1 year ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset aff897f876e43d7201b408de46e0d0a8ba9190fe.
#5
Updated by Dominic Cleal over 1 year ago
- Release set to 1.13.1
#6
Updated by Marek Hulán over 1 year ago
- Related to Bug #16899: All help buttons are broken added
#7
Updated by Dominic Cleal over 1 year ago
- Release changed from 1.13.1 to 1.14.0
Moving due to the issue and complex fix in #16899.