Project

General

Profile

Bug #16806

foreman_url template macro can't be used outside controller context

Added by Marek Hulán almost 2 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

When foreman_url is used in a template which is rendered out of controller context it fails with url_for. I'm afraid it's not reproducible with pure Foreman atm but the Renderer should include url helpers so once it's included, all it's macros can be used. The issue is easily reproducible from remote execution plugin, when foreman_url is put in job template and then previewed.


Related issues

Related to Foreman - Bug #16899: All help buttons are brokenClosed2016-10-13

Associated revisions

Revision aff897f8 (diff)
Added by Marek Hulán almost 2 years ago

Fixes #16806 - include renderer url dependencies

History

#1 Updated by Marek Hulán almost 2 years ago

  • Subject changed from foreman_url template macro can't be used outside controller context to foreman_url template macro can't be used outside controller context
  • Category set to Templates
  • Status changed from New to Assigned
  • Assignee set to Marek Hulán
  • Priority changed from High to Normal

#2 Updated by The Foreman Bot almost 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3919 added

#3 Updated by Marek Hulán almost 2 years ago

  • Target version set to 1.5.0

#4 Updated by Marek Hulán almost 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 2 years ago

  • Legacy Backlogs Release (now unused) set to 190

#6 Updated by Marek Hulán almost 2 years ago

  • Related to Bug #16899: All help buttons are broken added

#7 Updated by Dominic Cleal almost 2 years ago

  • Legacy Backlogs Release (now unused) changed from 190 to 189

Moving due to the issue and complex fix in #16899.

Also available in: Atom PDF