Bug #16846: Org create returns unclear message when trying to assign a non-existent subnet - Foreman

Actions

Copy link

Bug #16846

closed

Org create returns unclear message when trying to assign a non-existent subnet

Added by Adam Ruzicka about 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Amit Karsale

Category:

API

Target version:

1.15.0

Difficulty:

Triaged:

Bugzilla link:

1199604

Pull request:

https://github.com/theforeman/foreman/pull/4189

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1199604

Description of problem:

When testing bug #1183196, I inadvertently tried creating org, associating it with a subnet that did not exist. When this occurs, user gets an error message that seems to have nothing to do with the subnet.

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-7-20150303.0

How reproducible:

Steps to Reproduce:
1. Create capsules/smart proxiess; furthermore, create only one subnet. Or create zero, and modify hammer command below accordingly.
2. Attempt to create an org:
hammer organization create --description "eeee" --name "eeee" --smart-proxy-ids=2 --domain-ids 1 --subnet-ids 1,2
3. View results

Actual results:
[root@rhsm-qe-2 ~]# hammer organization create --description "eeee" --name "eeee" --smart-proxy-ids=2 --domain-ids 1 --subnet-ids 1,2
[Foreman] Username: admin
[Foreman] Password for admin:
Could not create the organization:
Resource organization not found by id ''

Expected results:

An error message that makes more sense -- "No subnet found for id '2'" or whatever

Additional info:

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Is duplicate of Bug #16813: Confusing error message on association not found error added

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Status changed from New to Duplicate

Those error messages are likely to be generated by the API, not Hammer. I think it's been fixed in #16813, please retest on develop.

Actions

Copy link

Updated by Adam Ruzicka about 8 years ago

On latest foreman, hammer-cli and hammer-cli-foreman I'm still getting the same error:

$ hammer organization create --name foobar --subnet-ids=9999
Could not create the organization:
  Resource organization not found by id ''

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Project changed from Hammer CLI to Foreman
Subject changed from Hammer: org create - unclear message when trying to assign a non-existent subnet to Org create returns unclear message when trying to assign a non-existent subnet
Category changed from Other commands to API
Status changed from Duplicate to New

Thanks for confirming. #16813 probably only fixed the *_name belongs_to extension (HasManyCommon), while the reverse relation depends on the *_ids collection setter behaviour, which always raises an AR::NotFound. The error handler may need improving for that exception.

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Is duplicate of deleted (Bug #16813: Confusing error message on association not found error)

Actions

Copy link

Updated by Dominic Cleal about 8 years ago

Related to Bug #16813: Confusing error message on association not found error added

Actions

Copy link

Updated by Marek Hulán about 8 years ago

Target version set to 115

Actions

Copy link

Updated by Amit Karsale about 8 years ago

here are we expecting a generic error message statement or error specific to a specific parameter wrongly passed,
as the current message is generic for any resource not found, maybe we can revise the error message from "no resource loaded" to something like "some of the attribute values are inappropriate." or should it be specific?

Actions

Copy link