Bug #16961
closed
katello-clean-empty-puppet-environments cron.weekly job needs to hide errors when trying to delete non-existent folders
Description
Description of problem:
The cron.weekly job put in place to clean empty puppet environments will now have situations where there are no KT_* environments to clean up. In this situation, the find command fails and an error is output. We should redirect the errors to null (hide them) or come up with a different command.
Version-Release number of selected component (if applicable):
Satellite 6.2.2.1
How reproducible:
100%
Steps to Reproduce:
1. Install Satellite 6.2
2. Have no publshed puppet environments. (KT_* folders are no longer created for content-views, so on if not modules are published)
3. Run /etc/cron.weekly/katello-clean-empty-puppet-environments
Actual results:
find: ‘/etc/puppet/environments/KT*’: No such file or directory
Expected results:
No errors from script output
Additional info:
Since the only purpose is to clean out unused puppet environments, we could simply add '> /dev/null 2>&1' to the end of the scripts `find` command, which will dismiss any and all errors.
If we want to retain errors for other issues, we can simply check for directory existence before-hand with simple if statements.
Updated by Craig Donnelly over 8 years ago
I just noticed upstream this was already taken care of with the below being the current check:
$ cat katello-clean-empty-puppet-environments
#!/bin/bash
- Puppet 4
[ -d /etc/puppetlabs/code/environments ] && find /etc/puppetlabs/code/environments/KT* -maxdepth 0 -type d -empty -delete
- Puppet 3
[ -d /etc/puppet/environments ] && find /etc/puppet/environments/KT* -maxdepth 0 -type d -empty -delete
This can be closed out.
Updated by Chris Roberts over 8 years ago
- Translation missing: en.field_release set to 166