Project

General

Profile

Feature #170

Create a usergroup implementation

Added by Paul Kelly over 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Paul Kelly
Category:
Web Interface
Target version:
0.1-5
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Create the MVC and testing infrastructure to support the usergroup concept.

170.patch 170.patch 22.3 KB Ohad Levy, 05/16/2010 04:08 PM
patch-squashed.diff patch-squashed.diff 59.1 KB Ohad Levy, 05/17/2010 06:52 AM

Related issues

Related to Foreman - Feature #139: per host authorization for making changes.Closed2009-12-18
Precedes Foreman - Feature #73: add support for user groupsClosed2010-03-042010-03-04

Associated revisions

Revision 9c0e127b (diff)
Added by Paul Kelly about 13 years ago

Fixes #170 - implement usergroups

Added migration
Added tests
Added MVC files
Added the routes as well
Added the program logic and additional views
Added RESTful actions for update and create
Added validations to ensure that usergroup.name and user.login do not collide
Added "recipients" method to users and usergroups. This returns a list of addresses.
Usergroup#recipients will follow all nested usergroups avoiding any loops and
return only unique addresses

Fixes #73 - Add usergroup support to hosts

Fixes #244 - Remove ActiveScaffold from the usergroup pages

and finally - added owners to host edit page and other whitespaces and
mods by ohad

Revision 8b62e7f3 (diff)
Added by Ohad Levy about 13 years ago

fixes typo in migration, refs #170

History

#1 Updated by Paul Kelly over 13 years ago

  • Status changed from New to Ready For Testing

This has been implemented in feature/73 on my github against the current edge. This includes the migration, MVC and tests. It is ready to be used by any model that wishes to use usergroups.
It uses has_may_polymorphs and integrates with ActiveScaffold for error returns.

#2 Updated by Ohad Levy over 13 years ago

the code looks great :)

Did you create a new feature because you didnt implement the host part?

can you switch the git submodule to .git?

please rebase to have one commit which closes the ticket ;)

thanks

#3 Updated by Ohad Levy about 13 years ago

  • Target version set to 0.1-5

#4 Updated by Paul Kelly about 13 years ago

  • Branch set to feature/170-usergroups

Rebased against develop.

#5 Updated by Ohad Levy about 13 years ago

Hi Paul,

I've started to work on some fixes to this, attached is my work in progress if you have time to continue...

#6 Updated by Ohad Levy about 13 years ago

  • File patch-squashed added

newer version of the patch

#7 Updated by Ohad Levy about 13 years ago

  • File deleted (patch-squashed)

#8 Updated by Ohad Levy about 13 years ago

Ohad Levy wrote:

newer version of the patch

added as diff so you can see it inline

#9 Updated by Paul Kelly about 13 years ago

  • % Done changed from 0 to 100

#10 Updated by Ohad Levy about 13 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF