Project

General

Profile

Bug #17007

Starting or canceling the build of a host fails if an ipv6 address is configured

Added by Robert Frank over 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
DNS
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

If I try to start or cancel the build of a host it fails with the following error:

Failed to save: Conflict IPv6 DNS record <fqdn>/<ipv6 address> already exists

The configured IPv6 address and the conflicting address are the same, but they use different case for the hex letters (configured IPv6 address uses lower case, conflicting address in error message uses upper case.
The source of the error is in the conflicts method in lib/net/dns/forward_record.rb:
@conflicts ||= [dns_lookup(hostname)].delete_if { |c| c == self }.compact

The IPv6 addresses returned by dns_lookup have upper case hex letters which causes c == self to be always false.
Forcing the lookup method in lib/net/dns.rb to return lower case IPv6 addresses solved this particular problem for me:
ip = resolver.getresource(query, Resolv::DNS::Resource::IN::AAAA).address.to_s.downcase

There might be other places which could have similar problems when comparing IPv6 addresses.


Related issues

Has duplicate Foreman - Bug #17075: IPv6 dns records always conflictingDuplicate2016-10-24

Associated revisions

Revision 0babfc65 (diff)
Added by Timo Goebel over 4 years ago

fixes #17007 - normalize dns records before comparison

Revision 1be1abec (diff)
Added by Timo Goebel over 4 years ago

fixes #17007 - normalize dns records before comparison

(cherry picked from commit 0babfc650c2207ddfb38223928067ee11c6046fb)

History

#1 Updated by Dominic Cleal over 4 years ago

  • Category set to DNS

#2 Updated by Dominic Cleal over 4 years ago

  • Has duplicate Bug #17075: IPv6 dns records always conflicting added

#3 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Timo Goebel
  • Pull request https://github.com/theforeman/foreman/pull/3967 added

#4 Updated by Timo Goebel over 4 years ago

  • Legacy Backlogs Release (now unused) set to 190

#5 Updated by Timo Goebel over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF