Bug #17135: Creating override-value-order for smart classes using CLI doesnt handle comma delimited order - Hammer CLI - Foreman

Actions

Copy link

Bug #17135

closed

Creating override-value-order for smart classes using CLI doesnt handle comma delimited order

Added by Ori Rabin about 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ori Rabin

Category:

Smart variables

Target version:

hammer-cli-0.11.0

Difficulty:

Triaged:

Bugzilla link:

1328613

Pull request:

https://github.com/theforeman/hammer-cli-foreman/pull/312, https://github.com/theforeman/hammer-cli/pull/246

Team Backlog:

Fixed in Releases:

Found in Releases:

In Kanboard:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1328613

Description of problem:

When setting an override-value-order for an sc-param hammer is not
correctly parsing the comma delimited order, rather taking that
comma delimited list as a single argument.

Version-Release number of selected component (if applicable):

Sat 6.1.7

How reproducible:

100%

Steps to Reproduce:
1. hammer -u admin -p password sc-param update --override true --default-value ["10.37.224.254"] --id 129 --parameter-type array --override-value-order fqdn','datacentre','region','lifecycle_environment','hostgroup','datacentre,lifecycle_environment'
2.
3.

Actual results:

It's creating a single order value
‘fqdn','datacentre','region','lifecycle_environment','hostgroup','datacentre,lifecycle_environment'

Expected results:

It should create an ordered list, ie.
fqdn
datacentre
region
lifecycle_environment
hostgroup
datacentre,lifecycle_environment

Additional info:

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Martin Bacovsky about 8 years ago

Blocked by Bug #17180: Parameters of type list can not include values containing commas added

Actions

Copy link

Updated by Martin Bacovsky about 8 years ago

I'd suggest to use List normalizer for the override-value-order parameter. It can be achieved by using Array type for override-value-order in https://github.com/theforeman/foreman/blob/698e916ce208b5040b83a908a058c83c94d158ee/app/controllers/api/v2/smart_class_parameters_controller.rb#L49

The normalizer needs to be fixed to support commas in the values (#17180) though. The related blocking issue was attached.

Actions

Copy link

Updated by Tomáš Strachota about 8 years ago

Category changed from Other commands to Smart variables

Actions

Copy link

Updated by Tomáš Strachota about 8 years ago

Subject changed from Creating override-value-order for smart classes using CLI doesnt handle comma delimited order to Indistinguishable multiple matchers for override value order
Status changed from New to Assigned
Assignee set to Tomáš Strachota
Target version set to 1.4.4

Actions

Copy link

Updated by Tomáš Strachota about 8 years ago

Subject changed from Indistinguishable multiple matchers for override value order to Creating override-value-order for smart classes using CLI doesnt handle comma delimited order
Status changed from Assigned to New
Assignee deleted (~~Tomáš Strachota~~)
Target version deleted (~~1.4.4~~)