Project

General

Profile

Actions

Bug #17191

closed

Failed upgrade step doesn't prevent the following steps to proceed

Added by Ivan Necas over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Upgrades
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1382503
Description of problem:

If there is an issue with running a step in the pre-upgrade script,
the upgrade script continues with the execution. This might lead to more
serious issues later in the upgrade and complicates the debugging.

Steps to Reproduce:
1. run upgrade in which some migration steps fail

Actual results:

The upgrade continues with next steps

Expected results:

The upgrade fails immediately, providing enough information about the error.

Actions #1

Updated by Ivan Necas over 7 years ago

  • Subject changed from Failed upgrade step doesn't prevent the following steps to proceed to Failed upgrade step doesn't prevent the following steps to proceed
  • Target version set to 1.3.2
Actions #2

Updated by Justin Sherrill over 7 years ago

  • translation missing: en.field_release set to 114
Actions #3

Updated by Ivan Necas about 7 years ago

Looking into this a bit deeper, this happens only when there are multiple execution steps inside on upgrade step: it seems the foreman_mirgate is the only place it happens https://github.com/Katello/katello-installer/blob/73140936fba3992482c72635801d9d99875cc6da/hooks/pre/30-upgrade.rb#L65

Actions #4

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • translation missing: en.field_release deleted (114)
  • Pull request https://github.com/Katello/katello-installer/pull/471 added
Actions #5

Updated by Ivan Necas about 7 years ago

  • Target version changed from 1.3.2 to 1.11.1
Actions #6

Updated by Justin Sherrill about 7 years ago

  • translation missing: en.field_release set to 219
Actions #7

Updated by Ivan Necas about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF