Actions
Bug #17204
closedSort setting UI category names/tabs consistently
Difficulty:
easy
Triaged:
Description
The category tabs in the Administer > Settings web UI are not explicitly sorted, so they can be inconsistent between installations or depend on load orders.
One installation I'm looking at has the order:
- Puppet
- General
- Auth
- Boot disk
- Provisioning
Another has:
- General
- Puppet
- Auth
- Provisioning
They should be explicitly sorted - possibly with "General" first, then the remainder alphabetically.
Updated by Swapnil Abnave over 7 years ago
- Target version set to 177
- Difficulty set to easy
Updated by The Foreman Bot over 7 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4590 added
Updated by Swapnil Abnave over 7 years ago
- Target version changed from 177 to 1.17.0-RC1
Updated by Swapnil Abnave about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset e642cd2bbac3d39857091315ee836c747cf43206.
Updated by Marek Hulán about 7 years ago
- Translation missing: en.field_release set to 240
Updated by Ohad Levy about 7 years ago
I'm getting
Oops, we're sorry but something went wrong undefined method `concat' for #<Setting::ActiveRecord_Relation:0x0000000b8a6ca8> Did you mean? count
when viewing the settings page.
full trace
ActionView::Template::Error undefined method `concat' for #<Setting::ActiveRecord_Relation:0x0000000b8a6ca8> Did you mean? count /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:124:in `method_missing' /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:94:in `method_missing' /home/foreman/git/foreman/app/models/setting.rb:80:in `stick_general_first' /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:65:in `block in stick_general_first' /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/relation.rb:351:in `scoping' /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:65:in `stick_general_first' /home/foreman/git/foreman/app/views/settings/index.html.erb:4:in `_84cb67813ece67555edd6061d77b3ce4' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/template.rb:159:in `block in render' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications.rb:164:in `block in instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications.rb:164:in `instrument' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/template.rb:354:in `instrument' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/template.rb:157:in `render' /home/foreman/gems/gems/deface-1.2.0/lib/deface/action_view_extensions.rb:41:in `render' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/template_renderer.rb:54:in `block (2 levels) in render_template' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications.rb:164:in `block in instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications.rb:164:in `instrument' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/template_renderer.rb:53:in `block in render_template' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/template_renderer.rb:61:in `render_with_layout' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/template_renderer.rb:52:in `render_template' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/template_renderer.rb:14:in `render' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/renderer.rb:42:in `render_template' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/renderer/renderer.rb:23:in `render' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/rendering.rb:104:in `_render_template' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/streaming.rb:217:in `_render_template' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/rendering.rb:83:in `render_to_body' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/rendering.rb:52:in `render_to_body' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/renderers.rb:142:in `render_to_body' /home/foreman/gems/gems/actionpack-5.0.4/lib/abstract_controller/rendering.rb:26:in `render' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/rendering.rb:36:in `render' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/core_ext/benchmark.rb:12:in `block in ms' /opt/rh/rh-ruby24/root/usr/share/ruby/benchmark.rb:308:in `realtime' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/core_ext/benchmark.rb:12:in `ms' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/instrumentation.rb:44:in `block in render' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime' /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/instrumentation.rb:43:in `render' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/implicit_render.rb:36:in `default_render' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/basic_implicit_render.rb:4:in `block in send_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/basic_implicit_render.rb:4:in `tap' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/abstract_controller/base.rb:188:in `process_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/rendering.rb:30:in `process_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/abstract_controller/callbacks.rb:20:in `block in process_action' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:126:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:455:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:448:in `block (2 levels) in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting' /home/foreman/git/foreman/app/controllers/concerns/application_shared.rb:15:in `set_timezone' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:382:in `block in make_lambda' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:285:in `block in halting' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:447:in `block in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:455:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:448:in `block (2 levels) in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting' /home/foreman/git/foreman/app/models/concerns/foreman/thread_session.rb:32:in `clear_thread' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:382:in `block in make_lambda' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:285:in `block in halting' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:447:in `block in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:455:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:448:in `block (2 levels) in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting' /home/foreman/git/foreman/app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in `set_topbar_sweeper_controller' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:382:in `block in make_lambda' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:285:in `block in halting' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:447:in `block in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:455:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:448:in `block (2 levels) in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting' /home/foreman/gems/gems/audited-4.5.0/lib/audited/sweeper.rb:14:in `around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:405:in `public_send' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:405:in `block in make_lambda' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:285:in `block in halting' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:447:in `block in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:455:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:448:in `block (2 levels) in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting' /home/foreman/gems/gems/audited-4.5.0/lib/audited/sweeper.rb:14:in `around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:405:in `public_send' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:405:in `block in make_lambda' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:285:in `block in halting' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:447:in `block in around' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:455:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:101:in `__run_callbacks__' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:90:in `run_callbacks' /home/foreman/gems/gems/actionpack-5.0.4/lib/abstract_controller/callbacks.rb:19:in `process_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/rescue.rb:20:in `process_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications.rb:164:in `block in instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/notifications.rb:164:in `instrument' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/instrumentation.rb:30:in `process_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal/params_wrapper.rb:248:in `process_action' /home/foreman/gems/gems/activerecord-5.0.4/lib/active_record/railties/controller_runtime.rb:18:in `process_action' /home/foreman/gems/gems/actionpack-5.0.4/lib/abstract_controller/base.rb:126:in `process' /home/foreman/gems/gems/actionview-5.0.4/lib/action_view/rendering.rb:30:in `process' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal.rb:190:in `dispatch' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_controller/metal.rb:262:in `dispatch' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/routing/route_set.rb:50:in `dispatch' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/routing/route_set.rb:32:in `serve' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/journey/router.rb:39:in `block in serve' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/journey/router.rb:26:in `each' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/journey/router.rb:26:in `serve' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/routing/route_set.rb:725:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/apipie-rails-0.5.1/lib/apipie/static_dispatcher.rb:65:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/rack/agent_hooks.rb:30:in `traced_call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/rack/browser_monitoring.rb:32:in `traced_call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/apipie-rails-0.5.1/lib/apipie/extractor/recorder.rb:132:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/apipie-rails-0.5.1/lib/apipie/middleware/checksum_in_headers.rb:27:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/git/foreman/lib/middleware/catch_json_parse_errors.rb:8:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/etag.rb:25:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/conditional_get.rb:25:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/head.rb:12:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:232:in `context' /home/foreman/gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:226:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/cookies.rb:613:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:97:in `__run_callbacks__' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:750:in `_run_call_callbacks' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/callbacks.rb:90:in `run_callbacks' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/callbacks.rb:36:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/remote_ip.rb:79:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/railties-5.0.4/lib/rails/rack/logger.rb:36:in `call_app' /home/foreman/gems/gems/railties-5.0.4/lib/rails/rack/logger.rb:26:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/sprockets-rails-3.2.0/lib/sprockets/rails/quiet_assets.rb:13:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/git/foreman/lib/middleware/tagged_logging.rb:18:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/request_id.rb:24:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/method_override.rb:22:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/runtime.rb:22:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/activesupport-5.0.4/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/executor.rb:12:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/actionpack-5.0.4/lib/action_dispatch/middleware/static.rb:136:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/sendfile.rb:111:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/secure_headers-3.6.7/lib/secure_headers/middleware.rb:12:in `call' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/railties-5.0.4/lib/rails/engine.rb:522:in `call' /home/foreman/gems/gems/railties-5.0.4/lib/rails/railtie.rb:193:in `public_send' /home/foreman/gems/gems/railties-5.0.4/lib/rails/railtie.rb:193:in `method_missing' /home/foreman/gems/gems/newrelic_rpm-4.3.0.335/lib/new_relic/agent/instrumentation/middleware_tracing.rb:92:in `call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/urlmap.rb:68:in `block in call' /home/foreman/gems/gems/rack-2.0.3/lib/rack/urlmap.rb:53:in `each' /home/foreman/gems/gems/rack-2.0.3/lib/rack/urlmap.rb:53:in `call' /root/.gem/gems/passenger-5.0.7/lib/phusion_passenger/rack/thread_handler_extension.rb:89:in `process_request' /root/.gem/gems/passenger-5.0.7/lib/phusion_passenger/request_handler/thread_handler.rb:149:in `accept_and_process_next_request' /root/.gem/gems/passenger-5.0.7/lib/phusion_passenger/request_handler/thread_handler.rb:110:in `main_loop' /root/.gem/gems/passenger-5.0.7/lib/phusion_passenger/request_handler.rb:414:in `block (3 levels) in start_threads' /root/.gem/gems/passenger-5.0.7/lib/phusion_passenger/utils.rb:111:in `block in create_thread_and_abort_on_exception' /home/foreman/gems/gems/logging-2.2.2/lib/logging/diagnostic_context.rb:474:in `block in create_with_logging_context'
Updated by Daniel Lobato Garcia about 7 years ago
Rails 5 incompatibility, just reproduced this myself. Thanks for the warning, I'll fix asap.
Updated by The Foreman Bot about 7 years ago
- Pull request https://github.com/theforeman/foreman/pull/4701 added
Actions