Project

General

Profile

Bug #17206

Use __ for js translation, not _

Added by Ondřej Pražák almost 2 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
Internationalization
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

We use () for translations in Ruby, but _ in js references lodash library, _() should be used for translating in js.

Associated revisions

Revision 3b060c44 (diff)
Added by Ondřej Pražák almost 2 years ago

Fixes #17206 - Use __() for js translations

Revision 4d2f80d8 (diff)
Added by Ondřej Pražák over 1 year ago

Fixes #17206 - Use __() for js translations

(cherry picked from commit 3b060c4423b79a6e386dd10d9eb7428bcd6d67e9)

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3993 added

#2 Updated by Marek Hulán almost 2 years ago

  • Target version set to 1.4.2

#3 Updated by Ondřej Pražák almost 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 2 years ago

  • Category set to Internationalization
  • Legacy Backlogs Release (now unused) set to 203

Also available in: Atom PDF