Plugins » Katello

Hi,
when upgrading to rhel 7.3 I noticed that the squid migration script did changes to the configuration that the foreman installer wanted to reverse. I looked into the issue and it seems that directive is not needed in any squid3 install.

[ INFO 2016-11-04 11:03:33 verbose] --- /etc/squid/squid.conf   2016-11-04 10:37:52.415874894 +0100
[ INFO 2016-11-04 11:03:33 verbose] +++ /tmp/puppet-file20161104-20432-ba9vol   2016-11-04 11:03:33.000000000 +0100
[ INFO 2016-11-04 11:03:33 verbose] @@ -51,9 +51,7 @@
[ INFO 2016-11-04 11:03:33 verbose]  
[ INFO 2016-11-04 11:03:33 verbose]  
[ INFO 2016-11-04 11:03:33 verbose]  # general settings
[ INFO 2016-11-04 11:03:33 verbose] -# migrated automatically by squid-migrate-conf, the original configuration was: hierarchy_stoplist             cgi-bin ?
[ INFO 2016-11-04 11:03:33 verbose] -acl migrated_hs_0_0 url_regex cgi\-bin \?
[ INFO 2016-11-04 11:03:33 verbose] -always_direct allow migrated_hs_0_0
[ INFO 2016-11-04 11:03:33 verbose] +hierarchy_stoplist             cgi-bin ?
[ INFO 2016-11-04 11:03:33 verbose]  coredump_dir                   /var/spool/squid
[ INFO 2016-11-04 11:03:33 verbose]  maximum_object_size_in_memory  100 MB
[ INFO 2016-11-04 11:03:33 verbose]  maximum_object_size            5 GB

I've suggested removing this directive from the upstream module (https://github.com/thias/puppet-squid3/pull/51).

During testing I noticed that another directive is obsolete aswell:
squid³⁶⁹²⁹: 2016/11/04 11:27:25| ERROR: Directive 'ignore_expect_100' is obsolete.
this was already fixed in upstream (https://github.com/thias/puppet-squid3/commit/a0af0547853c056517485138d84a17bfa60efb4f) and is in version 1.0.1 of that module.

I'll create a pr against puppet-pulp once my changes are accepted upstream and a new version is published.

this is not urgend, it only creates log entries but squid runs fine as far as I can tell.

Greetings,
Klaas