Project

General

Custom queries

Profile

Actions

Refactor #17354

closed

Test for idempotent operating system creation in Puppet fact parser

Added by Dominic Cleal over 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

There are small idempotency issues in the Puppet fact parser, leading to bugs such as #17335, where the OS is successfully created on the first run, but subsequent runs fail as the parser tried to recreate an existing OS.

The tests should be expanded to call importer.operatingsystem twice and to verify the OS is unchanged.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #17335: puppet_fact_parser.rb does not correctly add hosts facts whos minor number does not exist or is emptyClosedDominic Cleal11/15/2016Actions
#1

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #17335: puppet_fact_parser.rb does not correctly add hosts facts whos minor number does not exist or is empty added
#3

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4026 added
#4

Updated by Dominic Cleal over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
#5

Updated by Dominic Cleal over 8 years ago

  • Translation missing: en.field_release set to 189
Actions

Also available in: Atom PDF