Refactor #17439
Refactor facet base class to a concern.
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assignee: |  Shimon Shtein | ||
| Category: | Plugins-Engines | ||
| Target version: | 1.14.0 | ||
| Difficulty: | Team Backlog: | ||
| Triaged: | Fixed in Releases: | ||
| Bugzilla link: | Found in Releases: | ||
| Pull request: | https://github.com/theforeman/foreman/pull/4047 | ||
Description
We can leave the base class, but we want to leave the inheritance option open.
Example: In Katello there is a base class for all models, so we want to enable ContentFacet class to inherit the base Model and have all facet related methods.
Related issues
Associated revisions
Fixes #17439 - Moved facet base to a concern
If the plugin that wants to create a new facet doesn't want to
take the inheritance slot (for example if it already has some
base class), it can `include` the new concern.
Fixes #17439 - Moved facet base to a concern
If the plugin that wants to create a new facet doesn't want to
take the inheritance slot (for example if it already has some
base class), it can `include` the new concern.
(cherry picked from commit 1b38f231cc63f29a6bae0d0e2f8202c9bd674581)
History
#1
Updated by Shimon Shtein over 1 year ago
- Related to Refactor #16987: Explicit building of facets added
#2
Updated by The Foreman Bot over 1 year ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4047 added
#3
Updated by Shimon Shtein over 1 year ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 1b38f231cc63f29a6bae0d0e2f8202c9bd674581.
#4
Updated by Dominic Cleal over 1 year ago
- Category set to Plugins-Engines
- Legacy Backlogs Release (now unused) set to 189