Project

General

Profile

Actions
Copy link

Refactor #17439

closed

Refactor facet base class to a concern.

Added by Shimon Shtein about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shimon Shtein
Category:
Plugin integration
Target version:
1.14.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4047
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We can leave the base class, but we want to leave the inheritance option open.
Example: In Katello there is a base class for all models, so we want to enable ContentFacet class to inherit the base Model and have all facet related methods.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Refactor #16987: Explicit building of facetsClosedShimon Shtein10/18/2016Actions
Actions
Copy link
 #1

Updated by Shimon Shtein about 7 years ago

Actions
Copy link
 #2

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4047 added
Actions
Copy link
 #3

Updated by Shimon Shtein about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Dominic Cleal about 7 years ago

  • Category set to Plugin integration
  • translation missing: en.field_release set to 189
Actions
Copy link

Also available in: Atom PDF