Project

General

Profile

Bug #17482

Incorrect concatentation of environment import strings to form sentences

Added by Dominic Cleal about 4 years ago. Updated almost 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Some of the newly extracted strings in #15779 are incorrectly concatenated to form sentences. They must be extracted and translated as one - individual words can't be translated and added together, it will not work in some languages.

https://github.com/theforeman/foreman/commit/eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e#diff-e9a92ed45620b6f0de59ab2e0bd3c791R18
https://github.com/theforeman/foreman/commit/eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e#diff-e9a92ed45620b6f0de59ab2e0bd3c791R41

It's been separated into the form:

_("Update") + " " + _("environment") + name + " (5 " + _("classes") + ")" 

This should be:

_("Update environment %{environment} (%{count} classes)")

and should also use n_() to handle plural/non-plural forms.

The string "Update on background" is also added, which should be "Update in the background" or possibly, "Update in background".


Related issues

Related to Foreman - Feature #15779: Make report, puppet classes and environments importing asynchronous using foreman-tasksClosed2016-07-22

History

#1 Updated by Dominic Cleal about 4 years ago

  • Related to Feature #15779: Make report, puppet classes and environments importing asynchronous using foreman-tasks added

#2 Updated by Dominic Cleal about 4 years ago

  • Description updated (diff)

#3 Updated by Marek Hulán about 4 years ago

  • Assignee set to Marek Hulán
  • Target version set to 1.4.4

#4 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4054 added

#5 Updated by Marek Hulán about 4 years ago

  • Target version changed from 1.4.4 to 1.10.1

#6 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) changed from 189 to 209

#7 Updated by Marek Hulán almost 4 years ago

  • Target version changed from 1.10.1 to 1.10.2

#8 Updated by Marek Hulán almost 4 years ago

  • Target version changed from 1.10.2 to 1.11.2

#9 Updated by Marek Hulán almost 4 years ago

  • Target version changed from 1.11.2 to 1.11.4

#10 Updated by Marek Hulán almost 4 years ago

  • Target version changed from 1.11.4 to 1.12.1

#11 Updated by Dominic Cleal almost 4 years ago

  • Status changed from Ready For Testing to Rejected
  • Legacy Backlogs Release (now unused) deleted (209)

#15779 reverted, removing the strings.

Also available in: Atom PDF