Bug #17482
closedIncorrect concatentation of environment import strings to form sentences
Description
Some of the newly extracted strings in #15779 are incorrectly concatenated to form sentences. They must be extracted and translated as one - individual words can't be translated and added together, it will not work in some languages.
https://github.com/theforeman/foreman/commit/eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e#diff-e9a92ed45620b6f0de59ab2e0bd3c791R18
https://github.com/theforeman/foreman/commit/eb371ca33dcdd7a4f71d3cda0cfcad701cd3ae7e#diff-e9a92ed45620b6f0de59ab2e0bd3c791R41
It's been separated into the form:
_("Update") + " " + _("environment") + name + " (5 " + _("classes") + ")"
This should be:
_("Update environment %{environment} (%{count} classes)")
and should also use n_() to handle plural/non-plural forms.
The string "Update on background" is also added, which should be "Update in the background" or possibly, "Update in background".
Updated by Dominic Cleal almost 8 years ago
- Related to Feature #15779: Make report, puppet classes and environments importing asynchronous using foreman-tasks added
Updated by Marek Hulán almost 8 years ago
- Assignee set to Marek Hulán
- Target version set to 1.4.4
Updated by The Foreman Bot almost 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4054 added
Updated by Marek Hulán almost 8 years ago
- Target version changed from 1.4.4 to 1.10.1
Updated by Dominic Cleal almost 8 years ago
- Translation missing: en.field_release changed from 189 to 209
Updated by Marek Hulán almost 8 years ago
- Target version changed from 1.10.1 to 1.10.2
Updated by Marek Hulán over 7 years ago
- Target version changed from 1.10.2 to 1.11.2
Updated by Marek Hulán over 7 years ago
- Target version changed from 1.11.2 to 1.11.4
Updated by Marek Hulán over 7 years ago
- Target version changed from 1.11.4 to 1.12.1
Updated by Dominic Cleal over 7 years ago
- Status changed from Ready For Testing to Rejected
- Translation missing: en.field_release deleted (
209)
#15779 reverted, removing the strings.